#1738 - Refactor add final, Object.equals, Integer.compare

This commit is contained in:
rob bygrave committed 2019-06-29 00:23:12 +12:00
1 parent 8bfae9deef
commit 7fa5e2aa8c
52 files changed
+102 -120

No files matched your search

@@ -8,7 +8,7 @@ import java.io.IOException;
class CaseInsensitiveEqualExpression extends AbstractValueExpression {
private boolean not;
private final boolean not;
CaseInsensitiveEqualExpression(String propertyName, Object value, boolean not) {
super(propertyName, value);
@@ -60,7 +60,7 @@ public class DefaultExpressionList<T> implements SpiExpressionList<T> {
private final ExpressionList<T> parentExprList;
protected ExpressionFactory expr;
protected final ExpressionFactory expr;
String allDocNestedPath;
@@ -4,6 +4,7 @@ import io.ebeaninternal.api.SpiExpression;
import io.ebeaninternal.api.SpiExpressionRequest;
import java.io.IOException;
import java.util.Objects;
/**
* Generally speaking tests the value at a given path in the JSON document.
@@ -91,8 +92,8 @@ class JsonPathExpression extends AbstractExpression {
@Override
public boolean isSameByBind(SpiExpression other) {
JsonPathExpression that = (JsonPathExpression) other;
if (value != null ? !value.equals(that.value) : that.value != null) return false;
return upperValue != null ? upperValue.equals(that.upperValue) : that.upperValue == null;
if (!Objects.equals(value, that.value)) return false;
return Objects.equals(upperValue, that.upperValue);
}
@Override