No effective change - add final modifier

This commit is contained in:
Robin Bygrave committed 2015-07-31 14:02:38 +12:00
1 parent deed0bb01d
commit 90886193c0
42 files changed
+75 -81

No files matched your search

@@ -34,22 +34,22 @@ public class Packet {
/**
* The type of Packet.
*/
protected short packetType;
protected final short packetType;
/**
* The PacketId.
*/
protected long packetId;
protected final long packetId;
/**
* The timestamp the Packet was created.
*/
protected long timestamp;
protected final long timestamp;
/**
* The EbeanServer name this relates to if relevant.
*/
protected String serverName;
protected final String serverName;
protected ByteArrayOutputStream buffer;
protected DataOutputStream dataOut;
@@ -16,7 +16,7 @@ import java.util.List;
*/
public class IncomingPacketsLastAck {
private HashMap<String,MessageAck> lastAckMap = new HashMap<String, MessageAck>();
private final HashMap<String,MessageAck> lastAckMap = new HashMap<String, MessageAck>();
public String toString() {
return lastAckMap.values().toString();
@@ -103,9 +103,9 @@ public class IncomingPacketsProcessed {
/**
* Packets received out of order.
*/
private ArrayList<Long> outOfOrderList = new ArrayList<Long>();
private final ArrayList<Long> outOfOrderList = new ArrayList<Long>();
private HashMap<Long,Integer> resendCountMap = new HashMap<Long,Integer>();
private final HashMap<Long,Integer> resendCountMap = new HashMap<Long,Integer>();
public GotAllPoint(String memberKey, int maxResendIncoming) {
this.memberKey = memberKey;
@@ -102,12 +102,12 @@ public class McastClusterManager implements ClusterBroadcast, Runnable {
* Packets are cleared from the outgoingPacketsCache quicker at the cost of
* sending more packets.
*/
private long managerSleepMillis;
private final long managerSleepMillis;
/**
* When true then packets are still sent out even when the cluster has no other online members.
*/
private boolean sendWithNoMembers;
private final boolean sendWithNoMembers;
/**
* The current minAcked packetId processed by the managerThread.
@@ -143,7 +143,7 @@ public class McastClusterManager implements ClusterBroadcast, Runnable {
/**
* The max time we go without sending any packets.
*/
private int lastSendTimeFreqMillis;
private final int lastSendTimeFreqMillis;
/**
* The last time the cluster status was logged.
@@ -153,7 +153,7 @@ public class McastClusterManager implements ClusterBroadcast, Runnable {
/**
* The max time we go before logging the cluster status.
*/
private int lastStatusTimeFreqMillis;
private final int lastStatusTimeFreqMillis;
private long totalTxnEventsSent;
@@ -57,7 +57,7 @@ public class McastListener implements Runnable {
private DatagramPacket pack;
private byte[] receiveBuffer;
private final byte[] receiveBuffer;
private volatile boolean shutdown;
private volatile boolean shutdownComplete;
@@ -7,7 +7,7 @@ public class OutgoingPacketsAcked {
private long minimumGotAllPacketId;
private Map<String, GroupMemberAck> recievedByMap = new HashMap<String, GroupMemberAck>();
private final Map<String, GroupMemberAck> recievedByMap = new HashMap<String, GroupMemberAck>();
public int getGroupSize() {
synchronized (this) {