Improve test TestHistoryOneToOne

This commit is contained in:
Rob Bygrave committed 2022-04-20 10:02:11 +12:00
1 parent 0e6c6965f0
commit c766756efe
3 files changed
+16 -13

No files matched your search

@@ -10,7 +10,7 @@ import org.tests.model.draftable.BaseDomain;
@Entity @Entity
public class HistoryOneToOne extends BaseDomain { public class HistoryOneToOne extends BaseDomain {
String name; final String name;
@OneToOne(cascade = CascadeType.REFRESH) @OneToOne(cascade = CascadeType.REFRESH)
HistorylessOneToOne historylessOneToOne; HistorylessOneToOne historylessOneToOne;
@@ -19,14 +19,11 @@ public class HistoryOneToOne extends BaseDomain {
this.name = name; this.name = name;
} }
public HistoryOneToOne() { public HistorylessOneToOne less() {
}
public HistorylessOneToOne getHistorylessOneToOne() {
return historylessOneToOne; return historylessOneToOne;
} }
public void setHistorylessOneToOne(final HistorylessOneToOne historylessOneToOne) { public String getName() {
this.historylessOneToOne = historylessOneToOne; return name;
} }
} }
@@ -9,7 +9,7 @@ import javax.persistence.OneToOne;
@Entity @Entity
public class HistorylessOneToOne extends BaseDomain { public class HistorylessOneToOne extends BaseDomain {
private String name; private final String name;
/** /**
* This @OneToOne(mappedBy=...) side should really be FetchType.LAZY * This @OneToOne(mappedBy=...) side should really be FetchType.LAZY
@@ -17,8 +17,6 @@ public class HistorylessOneToOne extends BaseDomain {
@OneToOne(mappedBy = "historylessOneToOne", cascade = CascadeType.ALL, orphanRemoval = true)//, fetch = FetchType.LAZY) @OneToOne(mappedBy = "historylessOneToOne", cascade = CascadeType.ALL, orphanRemoval = true)//, fetch = FetchType.LAZY)
HistoryOneToOne historyOneToOne; HistoryOneToOne historyOneToOne;
public HistorylessOneToOne() {}
public HistorylessOneToOne(final String name) { public HistorylessOneToOne(final String name) {
this.name = name; this.name = name;
} }
@@ -30,4 +28,8 @@ public class HistorylessOneToOne extends BaseDomain {
public void setHistoryOneToOne(final HistoryOneToOne historyOneToOne) { public void setHistoryOneToOne(final HistoryOneToOne historyOneToOne) {
this.historyOneToOne = historyOneToOne; this.historyOneToOne = historyOneToOne;
} }
public String getName() {
return name;
}
} }
@@ -18,7 +18,7 @@ class TestHistoryOneToOne extends BaseTestCase {
@IgnorePlatform({Platform.ORACLE, Platform.COCKROACH}) @IgnorePlatform({Platform.ORACLE, Platform.COCKROACH})
@Test @Test
void test() throws InterruptedException { void test() throws InterruptedException {
HistorylessOneToOne historylessOneToOne = new HistorylessOneToOne(); HistorylessOneToOne historylessOneToOne = new HistorylessOneToOne("less");
historylessOneToOne.setHistoryOneToOne(new HistoryOneToOne("one")); historylessOneToOne.setHistoryOneToOne(new HistoryOneToOne("one"));
DB.save(historylessOneToOne); DB.save(historylessOneToOne);
Thread.sleep(20); Thread.sleep(20);
@@ -56,7 +56,9 @@ class TestHistoryOneToOne extends BaseTestCase {
assertThat(lessFetched.getId()).isEqualTo(expectedLessId); assertThat(lessFetched.getId()).isEqualTo(expectedLessId);
HistoryOneToOne history1 = lessFetched.getHistoryOneToOne(); HistoryOneToOne history1 = lessFetched.getHistoryOneToOne();
assertThat(history1.getId()).isEqualTo(expectedHistoryId); assertThat(history1.getId()).isEqualTo(expectedHistoryId);
assertThat(history1.getHistorylessOneToOne().getId()).isEqualTo(expectedLessId); assertThat(history1.less().getId()).isEqualTo(expectedLessId);
assertThat(history1.less().getName()).isEqualTo("less");
assertThat(history1.getName()).isEqualTo("one");
} }
@@ -81,6 +83,8 @@ class TestHistoryOneToOne extends BaseTestCase {
private void expected_viaHistory(HistoryOneToOne oneFetched) { private void expected_viaHistory(HistoryOneToOne oneFetched) {
assert oneFetched != null; assert oneFetched != null;
assertThat(oneFetched.getId()).isEqualTo(expectedHistoryId); assertThat(oneFetched.getId()).isEqualTo(expectedHistoryId);
assertThat(oneFetched.getHistorylessOneToOne().getId()).isEqualTo(expectedLessId); assertThat(oneFetched.less().getId()).isEqualTo(expectedLessId);
assertThat(oneFetched.less().getName()).isEqualTo("less");
assertThat(oneFetched.getName()).isEqualTo("one");
} }
} }