diff --git a/ebean-api/src/main/java/io/ebean/Transaction.java b/ebean-api/src/main/java/io/ebean/Transaction.java index c84db9c7d..06f6bd315 100644 --- a/ebean-api/src/main/java/io/ebean/Transaction.java +++ b/ebean-api/src/main/java/io/ebean/Transaction.java @@ -544,7 +544,9 @@ public interface Transaction extends AutoCloseable { * Deprecated migrate to connection(). */ @Deprecated - Connection getConnection(); + default Connection getConnection() { + return connection(); + } /** * Add table modification information to the TransactionEvent. diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanFkeyProperty.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanFkeyProperty.java index 7180f252a..8d7a31456 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanFkeyProperty.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanFkeyProperty.java @@ -135,7 +135,7 @@ public final class BeanFkeyProperty implements ElPropertyValue { * Returns null as not an AssocOne. */ @Override - public String getAssocIdInExpr(String prefix) { + public String assocIdInExpr(String prefix) { return null; } @@ -143,12 +143,12 @@ public final class BeanFkeyProperty implements ElPropertyValue { * Returns null as not an AssocOne. */ @Override - public String getAssocIdInValueExpr(boolean not, int size) { + public String assocIdInValueExpr(boolean not, int size) { return null; } @Override - public String getAssocIsEmpty(SpiExpressionRequest request, String path) { + public String assocIsEmpty(SpiExpressionRequest request, String path) { throw new RuntimeException("Not Supported or Expected"); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanProperty.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanProperty.java index 105c2a3d5..3f6117d54 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanProperty.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanProperty.java @@ -849,7 +849,7 @@ public class BeanProperty implements ElPropertyValue, Property, STreeProperty { } @Override - public String getAssocIsEmpty(SpiExpressionRequest request, String path) { + public String assocIsEmpty(SpiExpressionRequest request, String path) { // overridden in BanePropertyAssocMany throw new RuntimeException("Not Supported or Expected"); } @@ -867,13 +867,13 @@ public class BeanProperty implements ElPropertyValue, Property, STreeProperty { } @Override - public String getAssocIdInExpr(String prefix) { + public String assocIdInExpr(String prefix) { // Returns null as not an AssocOne. return null; } @Override - public String getAssocIdInValueExpr(boolean not, int size) { + public String assocIdInValueExpr(boolean not, int size) { // Returns null as not an AssocOne. return null; } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocMany.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocMany.java index 63608bdec..a1e28251b 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocMany.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocMany.java @@ -410,7 +410,7 @@ public class BeanPropertyAssocMany extends BeanPropertyAssoc implements ST } @Override - public String getAssocIsEmpty(SpiExpressionRequest request, String path) { + public String assocIsEmpty(SpiExpressionRequest request, String path) { boolean softDelete = targetDescriptor.isSoftDelete(); boolean needsX2Table = softDelete || getExtraWhere() != null; StringBuilder sb = new StringBuilder(50); @@ -470,7 +470,7 @@ public class BeanPropertyAssocMany extends BeanPropertyAssoc implements ST * Return the logical id value expression taking into account embedded id's. */ @Override - public String getAssocIdInValueExpr(boolean not, int size) { + public String assocIdInValueExpr(boolean not, int size) { return targetDescriptor.getIdBinder().getIdInValueExpr(not, size); } @@ -478,7 +478,7 @@ public class BeanPropertyAssocMany extends BeanPropertyAssoc implements ST * Return the logical id in expression taking into account embedded id's. */ @Override - public String getAssocIdInExpr(String prefix) { + public String assocIdInExpr(String prefix) { return targetDescriptor.getIdBinder().getAssocIdInExpr(prefix); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocOne.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocOne.java index 140de2f65..436cc8d8f 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocOne.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssocOne.java @@ -501,7 +501,7 @@ public class BeanPropertyAssocOne extends BeanPropertyAssoc implements STr * Return the logical id value expression taking into account embedded id's. */ @Override - public String getAssocIdInValueExpr(boolean not, int size) { + public String assocIdInValueExpr(boolean not, int size) { return targetDescriptor.getIdBinder().getIdInValueExpr(not, size); } @@ -509,7 +509,7 @@ public class BeanPropertyAssocOne extends BeanPropertyAssoc implements STr * Return the logical id in expression taking into account embedded id's. */ @Override - public String getAssocIdInExpr(String prefix) { + public String assocIdInExpr(String prefix) { return targetDescriptor.getIdBinder().getAssocIdInExpr(prefix); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyChain.java b/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyChain.java index a2c2c5e16..5fc82e99a 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyChain.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyChain.java @@ -166,8 +166,8 @@ public final class ElPropertyChain implements ElPropertyValue { } @Override - public String getAssocIsEmpty(SpiExpressionRequest request, String path) { - return lastElPropertyValue.getAssocIsEmpty(request, path); + public String assocIsEmpty(SpiExpressionRequest request, String path) { + return lastElPropertyValue.assocIsEmpty(request, path); } @Override @@ -183,13 +183,13 @@ public final class ElPropertyChain implements ElPropertyValue { } @Override - public String getAssocIdInExpr(String prefix) { - return lastElPropertyValue.getAssocIdInExpr(prefix); + public String assocIdInExpr(String prefix) { + return lastElPropertyValue.assocIdInExpr(prefix); } @Override - public String getAssocIdInValueExpr(boolean not, int size) { - return lastElPropertyValue.getAssocIdInValueExpr(not, size); + public String assocIdInValueExpr(boolean not, int size) { + return lastElPropertyValue.assocIdInValueExpr(not, size); } @Override diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyValue.java b/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyValue.java index f69b33040..e43559560 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyValue.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/el/ElPropertyValue.java @@ -14,17 +14,17 @@ public interface ElPropertyValue extends ElPropertyDeploy, ExpressionPath { /** * Return the logical id value expression taking into account embedded id's. */ - String getAssocIdInValueExpr(boolean not, int size); + String assocIdInValueExpr(boolean not, int size); /** * Return the logical id in expression taking into account embedded id's. */ - String getAssocIdInExpr(String prefix); + String assocIdInExpr(String prefix); /** * Return the logical where clause to support "Is empty". */ - String getAssocIsEmpty(SpiExpressionRequest request, String path); + String assocIsEmpty(SpiExpressionRequest request, String path); /** * Return true if this is an ManyToOne or OneToOne associated bean property. diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/expression/InExpression.java b/ebean-core/src/main/java/io/ebeaninternal/server/expression/InExpression.java index 843653538..16b79c1f4 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/expression/InExpression.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/expression/InExpression.java @@ -145,8 +145,8 @@ final class InExpression extends AbstractExpression { } if (prop != null) { - request.append(prop.getAssocIdInExpr(propName)); - request.append(prop.getAssocIdInValueExpr(not, bindValues.size())); + request.append(prop.assocIdInExpr(propName)); + request.append(prop.assocIdInValueExpr(not, bindValues.size())); } else { request.append(propName); request.appendInExpression(not, bindValues); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/expression/IsEmptyExpression.java b/ebean-core/src/main/java/io/ebeaninternal/server/expression/IsEmptyExpression.java index fc3be3e34..9896891de 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/expression/IsEmptyExpression.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/expression/IsEmptyExpression.java @@ -84,7 +84,7 @@ final class IsEmptyExpression extends AbstractExpression { } request .append("exists (select 1 from ") - .append(prop.getAssocIsEmpty(request, propertyPath)) + .append(prop.assocIsEmpty(request, propertyPath)) .append(")"); }