From fb8db14f3ad6d8b915049280234c807e31db6a06 Mon Sep 17 00:00:00 2001 From: rob bygrave Date: Tue, 31 Oct 2017 22:14:01 +1300 Subject: [PATCH] #1186 - Tidy, remove H2MultiValueBind for now --- .../server/core/InternalConfiguration.java | 8 +------ .../persist/platform/H2MultiValueBind.java | 23 ------------------- 2 files changed, 1 insertion(+), 30 deletions(-) delete mode 100644 src/main/java/io/ebeaninternal/server/persist/platform/H2MultiValueBind.java diff --git a/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java b/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java index 3b46d59c1..81d681208 100644 --- a/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java +++ b/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java @@ -43,7 +43,6 @@ import io.ebeaninternal.server.deploy.parse.DeployUtil; import io.ebeaninternal.server.expression.DefaultExpressionFactory; import io.ebeaninternal.server.persist.Binder; import io.ebeaninternal.server.persist.DefaultPersister; -import io.ebeaninternal.server.persist.platform.H2MultiValueBind; import io.ebeaninternal.server.persist.platform.MultiValueBind; import io.ebeaninternal.server.persist.platform.PostgresMultiValueBind; import io.ebeaninternal.server.query.CQueryEngine; @@ -274,15 +273,10 @@ public class InternalConfiguration { } private MultiValueBind createMultiValueBind(Platform platform) { + // only Postgres at this stage switch (platform) { case POSTGRES: return new PostgresMultiValueBind(); -// case H2: -// return new H2MultiValueBind(); -// case SQLSERVER: -// return new SqlServerTvpMultiValueHelp(); -// case ORACLE: -// return new OracleTvpMultiValueHelp(); default: return new MultiValueBind(); } diff --git a/src/main/java/io/ebeaninternal/server/persist/platform/H2MultiValueBind.java b/src/main/java/io/ebeaninternal/server/persist/platform/H2MultiValueBind.java deleted file mode 100644 index 8cf279a9e..000000000 --- a/src/main/java/io/ebeaninternal/server/persist/platform/H2MultiValueBind.java +++ /dev/null @@ -1,23 +0,0 @@ -package io.ebeaninternal.server.persist.platform; - -import io.ebeaninternal.server.type.ScalarType; - -/** - * Multi value binder that uses SqlServers Table-value parameters - * @author Roland Praml, FOCONIS AG - * - */ -public class H2MultiValueBind extends AbstractMultiValueBind { - - @Override - public String getInExpression(boolean not, ScalarType type, int size) { - String arrayType = getArrayType(type.getJdbcType()); - if (arrayType == null) { - return super.getInExpression(not, type, size); - } else { - StringBuilder sb = new StringBuilder(50); - sb.append(" in (select * from table(x ").append(arrayType).append(" = ?)) "); - return sb.toString(); - } - } -}