github/gitea
4
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-19 16:18:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: carry the API token on the doer (#39690)

Browse Source 
The token a request authenticated with now lives on the doer, so
permission and visibility checks apply its scope from the doer alone.
Replaces https://github.com/go-gitea/gitea/pull/39167, following
https://github.com/go-gitea/gitea/pull/39167#issuecomment-6063839619.

1. Public-only tokens get 404 instead of 403 for hidden users, orgs and
repos, like GitHub.
2. Org ownership, site admin, repo and org creation, generation and
transfer endpoints reject public-only tokens.
3. API pull request responses set `head.repo` to `null` and
`head.repo_id` to `-1` when the caller cannot see the head repository.
4. Public-only tokens see org memberships like anonymous callers, so
concealed members stay hidden.
5. Site admin access in activity feeds, follower lists, org members,
Actions run lists and packages needs a session or an `all`-scoped token.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwind
2026-10-19 00:34:01 +00:00
committed by GitHub
co-authored by wxiaoguang
parent 7e62dda791
commit 5264304a34
96 changed files with 583 additions and 686 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/web/middleware/data.go
-2
View File
@@ -16,8 +16,6 @@ const (
ContextDataKeySignedUser = "SignedUser"
// ContextDataKeyImpersonator holds the admin acting as the signed-in user, if any.
ContextDataKeyImpersonator = "Impersonator"
// ContextDataKeyAuthCredential names the credential the request authenticated with, e.g. "access-token:42".
ContextDataKeyAuthCredential = "AuthCredential"
)
func GetContextData(c context.Context) reqctx.ContextData {