github/gitea
4
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-11-13 22:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable nilnil linter for new code (#36591)

Browse Source 
Fixes: https://github.com/go-gitea/gitea/issues/36152

Enable the `nilnil` linter while adding `//nolint` comments to existing
violations. This will ensure no new issues enter the code base while we
can fix existing issues gradually.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
silverwindandClaude Opus 4.6 authored and GitHub committed 2026-02-16 09:57:18 +00:00
1 parent d9d66d04d0
commit a0160694b9
57 files changed
+86 -85
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

services/pull/check.go
+1 -1
View File
@@ -291,7 +291,7 @@ func getMergeCommit(ctx context.Context, pr *issues_model.PullRequest) (*git.Com
if err := gitrepo.RunCmdWithStderr(ctx, pr.BaseRepo, cmd); err != nil {
if gitcmd.IsErrorExitCode(err, 1) {
// prHeadRef is not an ancestor of the base branch
return nil, nil
return nil, nil //nolint:nilnil // return nil to indicate that the PR head is not merged
}
// Errors are signaled by a non-zero status that is not 1
return nil, fmt.Errorf("%-v git merge-base --is-ancestor: %w", pr, err)