mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-20 08:20:04 +00:00
42b1f95261
Bound the memory used when parsing uploaded packages, so instances with low memory limits survive non-standard packages. 1. Metadata files are read through a size-limited reader, archives themselves stay unbounded so large payloads keep working 2. zstd decoding caps the window at 128 MiB, the zstd CLI default 3. RPM headers go through a first-party reader with rpmlib's size and array count limits that allocates only what the upload contains, until https://github.com/sassoftware/go-rpmutils/pull/44 is released. Signing still verifies the payload digest, and its signature header matches rpmsign's byte for byte 4. Swift and NuGet read the zip entry they size-checked, a duplicate name could stand in for it before 5. Terraform states check `LIMIT_SIZE_TERRAFORM_STATE` before parsing, NuGet symbol PDBs share a 256 MiB budget 6. Oversized container configs are rejected instead of stored without metadata, invalid Vagrant boxes answer 400 instead of 500 Signed-off-by: techknowlogick <git@tklk.dev> Co-authored-by: techknowlogick <git@tklk.dev> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.com>
84 lines
2.1 KiB
Go
84 lines
2.1 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package packages
|
|
|
|
import (
|
|
"io"
|
|
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/util/filebuffer"
|
|
)
|
|
|
|
// HashedSizeReader provide methods to read, sum hashes and a Size method
|
|
type HashedSizeReader interface {
|
|
io.Reader
|
|
HashSummer
|
|
Size() int64
|
|
}
|
|
|
|
// HashedBuffer is buffer which calculates multiple checksums
|
|
type HashedBuffer struct {
|
|
*filebuffer.FileBackedBuffer
|
|
|
|
hash *MultiHasher
|
|
|
|
combinedWriter io.Writer
|
|
}
|
|
|
|
const DefaultMemorySize = 32 * 1024 * 1024
|
|
|
|
// NewHashedBuffer creates a hashed buffer with the default memory size
|
|
func NewHashedBuffer() (*HashedBuffer, error) {
|
|
return NewHashedBufferWithSize(DefaultMemorySize)
|
|
}
|
|
|
|
// NewHashedBufferWithSize creates a hashed buffer with a specific memory size
|
|
func NewHashedBufferWithSize(maxMemorySize int) (*HashedBuffer, error) {
|
|
tempDir, err := setting.AppDataTempDir("package-hashed-buffer").MkdirAllSub("")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
b := filebuffer.New(maxMemorySize, tempDir)
|
|
hash := NewMultiHasher()
|
|
|
|
combinedWriter := io.MultiWriter(b, hash)
|
|
|
|
return &HashedBuffer{
|
|
b,
|
|
hash,
|
|
combinedWriter,
|
|
}, nil
|
|
}
|
|
|
|
// CreateHashedBufferFromReader creates a hashed buffer with the default memory size and copies the provided reader data into it.
|
|
func CreateHashedBufferFromReader(r io.Reader) (*HashedBuffer, error) {
|
|
return CreateHashedBufferFromReaderWithSize(r, DefaultMemorySize)
|
|
}
|
|
|
|
// CreateHashedBufferFromReaderWithSize creates a hashed buffer and copies the provided reader data into it.
|
|
func CreateHashedBufferFromReaderWithSize(r io.Reader, maxMemorySize int) (*HashedBuffer, error) {
|
|
b, err := NewHashedBufferWithSize(maxMemorySize)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
_, err = io.Copy(b, r)
|
|
if err != nil {
|
|
_ = b.Close()
|
|
return nil, err
|
|
}
|
|
|
|
return b, nil
|
|
}
|
|
|
|
// Write implements io.Writer
|
|
func (b *HashedBuffer) Write(p []byte) (int, error) {
|
|
return b.combinedWriter.Write(p)
|
|
}
|
|
|
|
// Sums gets the MD5, SHA1, SHA256 and SHA512 checksums of the data
|
|
func (b *HashedBuffer) Sums() (hashMD5, hashSHA1, hashSHA256, hashSHA512 []byte) {
|
|
return b.hash.Sums()
|
|
}
|