mirror of
https://github.com/go-gost/x.git
synced 2026-10-20 17:11:35 +00:00
ginuerzh
a2e2810669
perf(pht): eliminate /authorize HTTP round-trip by self-generating CID Client now uses xid to generate connection IDs, removing one RTT per tunnel setup. Server lazily creates pipe pairs in handlePush/handlePull via getOrCreateConn helper, keeping backward compat for old clients that still call /authorize. fix: send close notification before canceling context Close() was canceling c.ctx before calling write(nil). With a canceled context, http.Client.Do returns immediately without network I/O, so the close notification POST never reached the server. Swap the order. fix: add Flush() after heartbeat write in handlePull w.Write() on http.ResponseWriter goes to a 2k bufio.Writer. Without a Flush(), the keepalive newline never reaches the wire, causing the client long-poll GET to time out. fix: use LoadOrStore in createPipe to prevent concurrent push/pull race When push and pull HTTP requests arrive concurrently for a new CID, both saw !ok from Load() and both called createPipe(), overwriting the first conns entry. The losing pipe pair leaked and the listener accepted a phantom connection. LoadOrStore makes the first Store win; the second caller gets the existing pipe. fix: close conn and delete entry on empty-data POST in handlePush A POST body of "\n" produced empty data after TrimSuffix, leaking the pipe pair and conns entry. Now always cleans up before returning. fix: use caller ctx instead of context.Background() in Dial Dial(ctx, addr) was discarding the caller context, so deadlines and cancellation did not propagate to the HTTP long-poll requests. fix: detect ListenAndServe failure in Init() and clean up goroutine Non-blocking select on errChan after starting the server goroutine surfaces immediate failures (port conflict, TLS error) instead of leaking a goroutine blocked on server.Accept(). chore: remove dead AuthorizePath from Client struct and dialer wiring Client no longer calls /authorize; the field and its metadata parsing in dialer/pht, dialer/http3 are dead code. test: add unit tests for createPipe race, close notification, empty-data cleanup, and queue-full fallback