github/minio
4
0 Fork 0
mirror of https://github.com/minio/minio.git synced 2026-11-13 14:44:19 +00:00
Code Issues Releases Wiki Activity

tracing: Support older admin tracing API (#11999)

Browse Source 
mc admin trace does not work with older MinIO versions because if an
incompability with older trace admin API. This commit changes madmin for
better backward compatibility with server admin API.
This commit is contained in:
Anis Elleuch authored and GitHub committed 2021-04-07 08:16:10 -07:00
1 parent a772379dc5
commit 0a1db6d41b
2 files changed
+15 -7
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

pkg/madmin/service-commands.go
+12 -4
View File
@@ -80,6 +80,8 @@ type ServiceTraceInfo struct {
// ServiceTraceOpts holds tracing options
type ServiceTraceOpts struct {
All bool // Deprecated
S3 bool
Internal bool
Storage bool
@@ -97,11 +99,17 @@ func (adm AdminClient) ServiceTrace(ctx context.Context, opts ServiceTraceOpts)
for {
urlValues := make(url.Values)
urlValues.Set("err", strconv.FormatBool(opts.OnlyErrors))
urlValues.Set("s3", strconv.FormatBool(opts.S3))
urlValues.Set("internal", strconv.FormatBool(opts.Internal))
urlValues.Set("storage", strconv.FormatBool(opts.Storage))
urlValues.Set("os", strconv.FormatBool(opts.OS))
urlValues.Set("threshold", opts.Threshold.String())
if opts.All {
// Deprecated flag
urlValues.Set("all", "true")
} else {
urlValues.Set("s3", strconv.FormatBool(opts.S3))
urlValues.Set("internal", strconv.FormatBool(opts.Internal))
urlValues.Set("storage", strconv.FormatBool(opts.Storage))
urlValues.Set("os", strconv.FormatBool(opts.OS))
}
reqData := requestData{
relPath: adminAPIPrefix + "/trace",
queryValues: urlValues,