add gocritic/ruleguard checks back again, cleanup code. (#13665)

- remove some duplicated code
- reported a bug, separately fixed in #13664
- using strings.ReplaceAll() when needed
- using filepath.ToSlash() use when needed
- remove all non-Go style comments from the codebase

Co-authored-by: Aditya Manthramurthy <donatello@users.noreply.github.com>
This commit is contained in:
HarshavardhanaandAditya Manthramurthy authored and GitHub committed 2021-11-16 09:28:29 -08:00
1 parent 07c5e72cdb
commit 661b263e77
111 files changed
+409 -450

No files matched your search

+2 -2
View File
@@ -274,7 +274,7 @@ func s3MetaToAzureProperties(ctx context.Context, s3Metadata map[string]string)
encodeKey := func(key string) string {
tokens := strings.Split(key, "_")
for i := range tokens {
tokens[i] = strings.Replace(tokens[i], "-", "_", -1)
tokens[i] = strings.ReplaceAll(tokens[i], "-", "_")
}
return strings.Join(tokens, "__")
}
@@ -367,7 +367,7 @@ func azurePropertiesToS3Meta(meta azblob.Metadata, props azblob.BlobHTTPHeaders,
decodeKey := func(key string) string {
tokens := strings.Split(key, "__")
for i := range tokens {
tokens[i] = strings.Replace(tokens[i], "_", "-", -1)
tokens[i] = strings.ReplaceAll(tokens[i], "_", "-")
}
return strings.Join(tokens, "_")
}