add gocritic/ruleguard checks back again, cleanup code. (#13665)

- remove some duplicated code
- reported a bug, separately fixed in #13664
- using strings.ReplaceAll() when needed
- using filepath.ToSlash() use when needed
- remove all non-Go style comments from the codebase

Co-authored-by: Aditya Manthramurthy <donatello@users.noreply.github.com>
This commit is contained in:
HarshavardhanaandAditya Manthramurthy authored and GitHub committed 2021-11-16 09:28:29 -08:00
1 parent 07c5e72cdb
commit 661b263e77
111 files changed
+409 -450

No files matched your search

+1
View File
@@ -54,6 +54,7 @@ func TestNetworkError_Unwrap(t *testing.T) {
n := &NetworkError{
Err: tt.err,
}
//nolint:gocritic
if tt.target == nil {
var netErrInterface net.Error
if errors.As(n, &netErrInterface) != tt.want {