From 99199a68b5bad55dd263aea6700e3d19284eda29 Mon Sep 17 00:00:00 2001
From: lwch <lwch748@gmail.com>
Date: Fri, 29 Jul 2022 14:45:45 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BC=98=E5=8C=96CodeQL=E9=97=AE=E9=A2=98?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 html/dashboard/js/terminal.js | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/html/dashboard/js/terminal.js b/html/dashboard/js/terminal.js
index 9896317..1582393 100644
--- a/html/dashboard/js/terminal.js
+++ b/html/dashboard/js/terminal.js
@@ -29,27 +29,25 @@ var page = {
         $('#tab-content>.active').removeClass('show').removeClass('active');
         var idx = page.idx;
         var str = `
-        <li class="nav-item">
+        <li class="nav-item" id="tab-${idx}">
             <button class="nav-link active" type="button">
                 shell - [${$('#terms option:selected').text()}]
             </button>
         </li>`;
-        var obj = $(str);
-        obj.click(function() {
+        $('#tabs').append($(str));
+        $("#tabs #tab-${idx}").click(function() {
             var $this = $(this);
             $('#tabs>.nav-item>.active').removeClass('active');
             $this.find('button').addClass('active');
             $('#tab-content>.active').removeClass('show').removeClass('active');
-            $('#tab-'+idx).addClass('show').addClass('active');
+            $('#tab-content-'+idx).addClass('show').addClass('active');
         });
-        $('#tabs').append(obj);
         var str = `
-        <div class="tab-pane fade show active" id="tab-${idx}">
+        <div class="tab-pane fade show active" id="tab-content-${idx}">
             <iframe src="http://${location.hostname}:${$('#terms').val()}"
                     style="width:100%;min-height:800px" allowfullscreen></iframe>
         </div>`;
-        var obj = $(str);
-        $('#tab-content').append(obj);
+        $('#tab-content').append($(str));
         page.idx++;
     },
     idx: 0