From 5af7e7438a3993f9db7ac359ffcf973cbb3cfe46 Mon Sep 17 00:00:00 2001 From: matt Date: Fri, 11 Sep 2026 11:45:59 +0800 Subject: [PATCH] fix(ci): check deferred sql.DB.Close errors in setup tests PR #6499 merged without CI ever running on its head commit (fork run stayed action_required), landing three bare `defer db.Close()` calls in internal/setup/setup_test.go. The repo's errcheck config sets disable-default-exclusions: true, so those are reported and golangci-lint has been red on main ever since, failing every subsequent PR run. Switch them to the codebase's existing convention `defer func() { _ = db.Close() }()`. --- backend/internal/setup/setup_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/internal/setup/setup_test.go b/backend/internal/setup/setup_test.go index 65d14f57a8..71abebc0c9 100644 --- a/backend/internal/setup/setup_test.go +++ b/backend/internal/setup/setup_test.go @@ -270,7 +270,7 @@ func TestDatabaseConnectionUsesConfiguredTargetBeforeBootstrapDatabase(t *testin if err != nil { t.Fatalf("sqlmock.New() error = %v", err) } - defer targetDB.Close() + defer func() { _ = targetDB.Close() }() var opened []string openDatabase := func(_ *DatabaseConfig, dbName string) (*sql.DB, error) { @@ -292,12 +292,12 @@ func TestDatabaseConnectionUsesLegacyBootstrapOnlyForMissingTarget(t *testing.T) if err != nil { t.Fatalf("sqlmock.New() bootstrap error = %v", err) } - defer bootstrapDB.Close() + defer func() { _ = bootstrapDB.Close() }() targetDB, _, err := sqlmock.New() if err != nil { t.Fatalf("sqlmock.New() target error = %v", err) } - defer targetDB.Close() + defer func() { _ = targetDB.Close() }() bootstrapMock.ExpectQuery(`SELECT EXISTS\(SELECT 1 FROM pg_database WHERE datname = \$1\)`). WithArgs(cfg.DBName).