refactor(frontend): merge Codex image bridge and tool policy into one four-state control

Replace the two adjacent account-level controls (3-state injection bridge
+ 2-state explicit tool policy) in EditAccountModal with a single
four-state selector: follow channel / force inject / no injection /
block all. The four states map onto the existing extra keys
(codex_image_generation_bridge, codex_image_generation_explicit_tool_policy)
with no backend change; strip already disables the bridge upstream, so
the effective decision space is exactly these four states.

- load: strip takes precedence and reads as "block all"; legacy
  bridge_enabled key still recognized and cleaned up on save
- save: block writes policy=strip and drops the bridge override;
  inherit clears both keys
- semantic accent colors per state (sky/emerald/amber/rose) with dark
  mode support; state badge follows the same palette
- replace account-scope i18n keys in zh/en (channel-scope keys untouched)
- rewrite specs to cover all four states (25/25 passing)
This commit is contained in:
shaw
2026-07-04 09:49:37 +08:00
parent dfdb838ce4
commit be297b90ce
4 changed files with 126 additions and 159 deletions
@@ -1370,7 +1370,7 @@
</div>
</div>
<!-- OpenAI Codex 图片生成桥接账号级覆盖 -->
<!-- OpenAI Codex 图片工具统一策略(自动注入 + 客户端显式携带) -->
<div
v-if="account?.platform === 'openai' && (account?.type === 'oauth' || account?.type === 'setup-token' || account?.type === 'apikey')"
class="border-t border-gray-200 pt-4 dark:border-dark-600"
@@ -1382,91 +1382,39 @@
</div>
<div class="min-w-0 flex-1">
<div class="flex flex-wrap items-center gap-2">
<label class="input-label mb-0">{{ t('admin.accounts.openai.codexImageGenerationBridge') }}</label>
<label class="input-label mb-0">{{ t('admin.accounts.openai.codexImageTool') }}</label>
<span
class="rounded-full px-2 py-0.5 text-[11px] font-medium"
:class="codexImageGenerationBridgeBadgeClass"
:class="codexImageToolBadgeClass"
>
{{ codexImageGenerationBridgeBadgeLabel }}
{{ codexImageToolBadgeLabel }}
</span>
</div>
<p class="mt-1 text-xs leading-5 text-slate-600 dark:text-slate-300">
{{ t('admin.accounts.openai.codexImageGenerationBridgeDesc') }}
{{ t('admin.accounts.openai.codexImageToolDesc') }}
</p>
</div>
</div>
<div class="border-t border-sky-100 bg-white/70 p-2 dark:border-sky-900/50 dark:bg-dark-800/70">
<div class="grid grid-cols-1 gap-2 sm:grid-cols-3">
<div class="grid grid-cols-1 gap-2 sm:grid-cols-2">
<button
v-for="option in codexImageGenerationBridgeOptions"
v-for="option in codexImageToolOptions"
:key="option.value"
type="button"
:data-testid="`codex-image-bridge-${option.value}`"
@click="codexImageGenerationBridgeMode = option.value"
:data-testid="`codex-image-tool-${option.value}`"
@click="codexImageToolMode = option.value"
:class="[
'group flex min-h-[68px] items-start gap-2 rounded-md border px-3 py-2 text-left transition-all',
codexImageGenerationBridgeMode === option.value
? 'border-sky-300 bg-sky-50 text-sky-900 shadow-sm ring-1 ring-sky-200 dark:border-sky-700 dark:bg-sky-900/25 dark:text-sky-100 dark:ring-sky-800'
'group flex min-h-[62px] items-start gap-2 rounded-md border px-3 py-2 text-left transition-all',
codexImageToolMode === option.value
? option.selectedCardClass
: 'border-transparent bg-transparent text-slate-600 hover:border-gray-200 hover:bg-gray-50 dark:text-slate-300 dark:hover:border-dark-500 dark:hover:bg-dark-700'
]"
>
<span
:class="[
'mt-0.5 flex h-5 w-5 shrink-0 items-center justify-center rounded-full border transition-colors',
codexImageGenerationBridgeMode === option.value
? 'border-sky-500 bg-sky-500 text-white'
: 'border-gray-300 text-transparent group-hover:border-gray-400 dark:border-dark-500'
]"
>
<Icon name="check" size="xs" :stroke-width="2" />
</span>
<span class="min-w-0">
<span class="block text-sm font-medium">{{ option.label }}</span>
<span class="mt-0.5 block text-xs leading-4 text-slate-500 dark:text-slate-400">{{ option.description }}</span>
</span>
</button>
</div>
</div>
</div>
</div>
<!-- OpenAI Codex 显式 image_generation tool 策略 -->
<div
v-if="account?.platform === 'openai' && (account?.type === 'oauth' || account?.type === 'setup-token' || account?.type === 'apikey')"
class="border-t border-gray-200 pt-4 dark:border-dark-600"
>
<div class="overflow-hidden rounded-lg border border-gray-200 bg-white shadow-sm dark:border-dark-600 dark:bg-dark-800">
<div class="flex items-start gap-3 px-4 py-3">
<div class="mt-0.5 flex h-9 w-9 shrink-0 items-center justify-center rounded-md bg-gray-50 text-slate-600 ring-1 ring-gray-200 dark:bg-dark-700 dark:text-slate-300 dark:ring-dark-600">
<Icon name="filter" size="sm" />
</div>
<div class="min-w-0 flex-1">
<label class="input-label mb-0">{{ t('admin.accounts.openai.codexImageToolPolicy') }}</label>
<p class="mt-1 text-xs leading-5 text-slate-600 dark:text-slate-300">
{{ t('admin.accounts.openai.codexImageToolPolicyDesc') }}
</p>
</div>
</div>
<div class="border-t border-gray-200 bg-gray-50/70 p-2 dark:border-dark-600 dark:bg-dark-700/50">
<div class="grid grid-cols-1 gap-2 sm:grid-cols-2">
<button
v-for="option in codexImageToolPolicyOptions"
:key="option.value"
type="button"
:data-testid="`codex-image-tool-policy-${option.value}`"
@click="codexImageToolPolicyMode = option.value"
:class="[
'group flex min-h-[62px] items-start gap-2 rounded-md border px-3 py-2 text-left transition-all',
codexImageToolPolicyMode === option.value
? 'border-slate-300 bg-white text-slate-900 shadow-sm ring-1 ring-slate-200 dark:border-slate-600 dark:bg-dark-800 dark:text-slate-100 dark:ring-dark-500'
: 'border-transparent bg-transparent text-slate-600 hover:border-gray-200 hover:bg-white dark:text-slate-300 dark:hover:border-dark-500 dark:hover:bg-dark-800'
]"
>
<span
:class="[
'mt-0.5 flex h-5 w-5 shrink-0 items-center justify-center rounded-full border transition-colors',
codexImageToolPolicyMode === option.value
? 'border-slate-600 bg-slate-700 text-white dark:border-slate-400 dark:bg-slate-500'
codexImageToolMode === option.value
? option.selectedDotClass
: 'border-gray-300 text-transparent group-hover:border-gray-400 dark:border-dark-500'
]"
>
@@ -2679,10 +2627,8 @@ const openaiOAuthResponsesWebSocketV2Mode = ref<OpenAIWSMode>(OPENAI_WS_MODE_OFF
const openaiAPIKeyResponsesWebSocketV2Mode = ref<OpenAIWSMode>(OPENAI_WS_MODE_OFF)
const codexCLIOnlyEnabled = ref(false)
const codexCLIOnlyAppServerEnabled = ref(false)
type CodexImageGenerationBridgeMode = 'inherit' | 'enabled' | 'disabled'
const codexImageGenerationBridgeMode = ref<CodexImageGenerationBridgeMode>('inherit')
type CodexImageToolPolicyMode = 'allow' | 'strip'
const codexImageToolPolicyMode = ref<CodexImageToolPolicyMode>('allow')
type CodexImageToolMode = 'inherit' | 'enabled' | 'disabled' | 'block'
const codexImageToolMode = ref<CodexImageToolMode>('inherit')
type AnthropicAPIKeyAuthScheme = 'x_api_key' | 'authorization_bearer'
const anthropicPassthroughEnabled = ref(false)
const anthropicAPIKeyAuthScheme = ref<AnthropicAPIKeyAuthScheme>('x_api_key')
@@ -2736,58 +2682,61 @@ const openaiResponsesWebSocketV2Mode = computed({
const openAIWSModeConcurrencyHintKey = computed(() =>
resolveOpenAIWSModeConcurrencyHintKey(openaiResponsesWebSocketV2Mode.value)
)
const codexImageGenerationBridgeOptions = computed<Array<{
value: CodexImageGenerationBridgeMode
const codexImageToolOptions = computed<Array<{
value: CodexImageToolMode
label: string
description: string
selectedCardClass: string
selectedDotClass: string
}>>(() => [
{
value: 'inherit',
label: t('admin.accounts.openai.codexImageGenerationBridgeInherit'),
description: t('admin.accounts.openai.codexImageGenerationBridgeInheritDesc')
label: t('admin.accounts.openai.codexImageToolInherit'),
description: t('admin.accounts.openai.codexImageToolInheritDesc'),
selectedCardClass: 'border-sky-300 bg-sky-50 text-sky-900 shadow-sm ring-1 ring-sky-200 dark:border-sky-700 dark:bg-sky-900/25 dark:text-sky-100 dark:ring-sky-800',
selectedDotClass: 'border-sky-500 bg-sky-500 text-white'
},
{
value: 'enabled',
label: t('admin.accounts.openai.codexImageGenerationBridgeEnabled'),
description: t('admin.accounts.openai.codexImageGenerationBridgeEnabledDesc')
label: t('admin.accounts.openai.codexImageToolEnabled'),
description: t('admin.accounts.openai.codexImageToolEnabledDesc'),
selectedCardClass: 'border-emerald-300 bg-emerald-50 text-emerald-900 shadow-sm ring-1 ring-emerald-200 dark:border-emerald-700 dark:bg-emerald-900/25 dark:text-emerald-100 dark:ring-emerald-800',
selectedDotClass: 'border-emerald-500 bg-emerald-500 text-white'
},
{
value: 'disabled',
label: t('admin.accounts.openai.codexImageGenerationBridgeDisabled'),
description: t('admin.accounts.openai.codexImageGenerationBridgeDisabledDesc')
}
])
const codexImageToolPolicyOptions = computed<Array<{
value: CodexImageToolPolicyMode
label: string
description: string
}>>(() => [
{
value: 'allow',
label: t('admin.accounts.openai.codexImageToolPolicyAllow'),
description: t('admin.accounts.openai.codexImageToolPolicyAllowDesc')
label: t('admin.accounts.openai.codexImageToolDisabled'),
description: t('admin.accounts.openai.codexImageToolDisabledDesc'),
selectedCardClass: 'border-amber-300 bg-amber-50 text-amber-900 shadow-sm ring-1 ring-amber-200 dark:border-amber-700 dark:bg-amber-900/25 dark:text-amber-100 dark:ring-amber-800',
selectedDotClass: 'border-amber-500 bg-amber-500 text-white'
},
{
value: 'strip',
label: t('admin.accounts.openai.codexImageToolPolicyStrip'),
description: t('admin.accounts.openai.codexImageToolPolicyStripDesc')
value: 'block',
label: t('admin.accounts.openai.codexImageToolBlock'),
description: t('admin.accounts.openai.codexImageToolBlockDesc'),
selectedCardClass: 'border-rose-300 bg-rose-50 text-rose-900 shadow-sm ring-1 ring-rose-200 dark:border-rose-700 dark:bg-rose-900/25 dark:text-rose-100 dark:ring-rose-800',
selectedDotClass: 'border-rose-500 bg-rose-500 text-white'
}
])
const codexImageGenerationBridgeBadgeLabel = computed(() => {
switch (codexImageGenerationBridgeMode.value) {
const codexImageToolBadgeLabel = computed(() => {
switch (codexImageToolMode.value) {
case 'enabled':
return t('admin.accounts.openai.codexImageGenerationBridgeBadgeEnabled')
return t('admin.accounts.openai.codexImageToolBadgeEnabled')
case 'disabled':
return t('admin.accounts.openai.codexImageGenerationBridgeBadgeDisabled')
return t('admin.accounts.openai.codexImageToolBadgeDisabled')
case 'block':
return t('admin.accounts.openai.codexImageToolBadgeBlock')
default:
return t('admin.accounts.openai.codexImageGenerationBridgeBadgeInherit')
return t('admin.accounts.openai.codexImageToolBadgeInherit')
}
})
const codexImageGenerationBridgeBadgeClass = computed(() => {
switch (codexImageGenerationBridgeMode.value) {
const codexImageToolBadgeClass = computed(() => {
switch (codexImageToolMode.value) {
case 'enabled':
return 'bg-emerald-100 text-emerald-700 dark:bg-emerald-900/40 dark:text-emerald-300'
case 'disabled':
return 'bg-amber-100 text-amber-700 dark:bg-amber-900/40 dark:text-amber-300'
case 'block':
return 'bg-rose-100 text-rose-700 dark:bg-rose-900/40 dark:text-rose-300'
default:
return 'bg-slate-100 text-slate-600 dark:bg-dark-600 dark:text-slate-300'
@@ -3105,8 +3054,7 @@ const syncFormFromAccount = (newAccount: Account | null) => {
openaiAPIKeyResponsesWebSocketV2Mode.value = OPENAI_WS_MODE_OFF
codexCLIOnlyEnabled.value = false
codexCLIOnlyAppServerEnabled.value = false
codexImageGenerationBridgeMode.value = 'inherit'
codexImageToolPolicyMode.value = 'allow'
codexImageToolMode.value = 'inherit'
anthropicPassthroughEnabled.value = false
anthropicAPIKeyAuthScheme.value = 'x_api_key'
webSearchEmulationMode.value = 'default'
@@ -3125,14 +3073,13 @@ const syncFormFromAccount = (newAccount: Account | null) => {
const codexImageGenerationBridgeValue = typeof extra?.codex_image_generation_bridge === 'boolean'
? extra.codex_image_generation_bridge
: extra?.codex_image_generation_bridge_enabled
if (codexImageGenerationBridgeValue === true) {
codexImageGenerationBridgeMode.value = 'enabled'
if (extra?.codex_image_generation_explicit_tool_policy === 'strip') {
codexImageToolMode.value = 'block'
} else if (codexImageGenerationBridgeValue === true) {
codexImageToolMode.value = 'enabled'
} else if (codexImageGenerationBridgeValue === false) {
codexImageGenerationBridgeMode.value = 'disabled'
codexImageToolMode.value = 'disabled'
}
codexImageToolPolicyMode.value = extra?.codex_image_generation_explicit_tool_policy === 'strip'
? 'strip'
: 'allow'
openaiOAuthResponsesWebSocketV2Mode.value = resolveOpenAIWSModeFromExtra(extra, {
modeKey: 'openai_oauth_responses_websockets_v2_mode',
enabledKey: 'openai_oauth_responses_websockets_v2_enabled',
@@ -4277,15 +4224,19 @@ const handleSubmit = async () => {
}
delete newExtra.codex_image_generation_bridge_enabled
if (codexImageGenerationBridgeMode.value === 'inherit') {
delete newExtra.codex_image_generation_bridge
} else {
newExtra.codex_image_generation_bridge = codexImageGenerationBridgeMode.value === 'enabled'
}
if (codexImageToolPolicyMode.value === 'strip') {
newExtra.codex_image_generation_explicit_tool_policy = 'strip'
} else {
delete newExtra.codex_image_generation_explicit_tool_policy
switch (codexImageToolMode.value) {
case 'enabled':
case 'disabled':
newExtra.codex_image_generation_bridge = codexImageToolMode.value === 'enabled'
delete newExtra.codex_image_generation_explicit_tool_policy
break
case 'block':
newExtra.codex_image_generation_explicit_tool_policy = 'strip'
delete newExtra.codex_image_generation_bridge
break
default:
delete newExtra.codex_image_generation_bridge
delete newExtra.codex_image_generation_explicit_tool_policy
}
if (props.account.type === 'oauth' || props.account.type === 'setup-token') {
@@ -611,7 +611,7 @@ describe('EditAccountModal', () => {
expect(updateAccountMock.mock.calls[0]?.[1]?.extra?.openai_responses_supported).toBe(true)
})
it('submits account-level Codex image generation bridge override', async () => {
it('submits Codex image tool force-inject mode as bridge override', async () => {
const account = buildAccount()
account.extra = {
codex_image_generation_bridge: false,
@@ -624,15 +624,16 @@ describe('EditAccountModal', () => {
const wrapper = mountModal(account)
await wrapper.get('button[data-testid="codex-image-bridge-enabled"]').trigger('click')
await wrapper.get('button[data-testid="codex-image-tool-enabled"]').trigger('click')
await wrapper.get('form#edit-account-form').trigger('submit.prevent')
expect(updateAccountMock).toHaveBeenCalledTimes(1)
expect(updateAccountMock.mock.calls[0]?.[1]?.extra?.codex_image_generation_bridge).toBe(true)
expect(updateAccountMock.mock.calls[0]?.[1]?.extra).not.toHaveProperty('codex_image_generation_bridge_enabled')
expect(updateAccountMock.mock.calls[0]?.[1]?.extra).not.toHaveProperty('codex_image_generation_explicit_tool_policy')
})
it('submits account-level Codex image_generation tool strip policy', async () => {
it('submits Codex image tool no-injection mode without strip policy', async () => {
const account = buildAccount()
updateAccountMock.mockReset()
checkMixedChannelRiskMock.mockReset()
@@ -641,14 +642,35 @@ describe('EditAccountModal', () => {
const wrapper = mountModal(account)
await wrapper.get('button[data-testid="codex-image-tool-policy-strip"]').trigger('click')
await wrapper.get('button[data-testid="codex-image-tool-disabled"]').trigger('click')
await wrapper.get('form#edit-account-form').trigger('submit.prevent')
expect(updateAccountMock).toHaveBeenCalledTimes(1)
expect(updateAccountMock.mock.calls[0]?.[1]?.extra?.codex_image_generation_bridge).toBe(false)
expect(updateAccountMock.mock.calls[0]?.[1]?.extra).not.toHaveProperty('codex_image_generation_explicit_tool_policy')
})
it('submits Codex image tool block mode as strip policy and clears bridge override', async () => {
const account = buildAccount()
account.extra = {
codex_image_generation_bridge: true
}
updateAccountMock.mockReset()
checkMixedChannelRiskMock.mockReset()
checkMixedChannelRiskMock.mockResolvedValue({ has_risk: false })
updateAccountMock.mockResolvedValue(account)
const wrapper = mountModal(account)
await wrapper.get('button[data-testid="codex-image-tool-block"]').trigger('click')
await wrapper.get('form#edit-account-form').trigger('submit.prevent')
expect(updateAccountMock).toHaveBeenCalledTimes(1)
expect(updateAccountMock.mock.calls[0]?.[1]?.extra?.codex_image_generation_explicit_tool_policy).toBe('strip')
expect(updateAccountMock.mock.calls[0]?.[1]?.extra).not.toHaveProperty('codex_image_generation_bridge')
})
it('keeps account-level Codex image_generation tool policy unset when allowing', async () => {
it('loads strip policy as block mode and clears both keys when reset to inherit', async () => {
const account = buildAccount()
account.extra = {
codex_image_generation_explicit_tool_policy: 'strip'
@@ -660,11 +682,12 @@ describe('EditAccountModal', () => {
const wrapper = mountModal(account)
await wrapper.get('button[data-testid="codex-image-tool-policy-allow"]').trigger('click')
await wrapper.get('button[data-testid="codex-image-tool-inherit"]').trigger('click')
await wrapper.get('form#edit-account-form').trigger('submit.prevent')
expect(updateAccountMock).toHaveBeenCalledTimes(1)
expect(updateAccountMock.mock.calls[0]?.[1]?.extra).not.toHaveProperty('codex_image_generation_explicit_tool_policy')
expect(updateAccountMock.mock.calls[0]?.[1]?.extra).not.toHaveProperty('codex_image_generation_bridge')
})
it('setup-token account can select and submit OAuth WS mode', async () => {