fix(logger): resolve Windows pipe fsync deadlock in tests

Remove Sync() calls in logger tests that use os.Pipe for stdout/stderr
capture. On Windows, FlushFileBuffers on pipe handles blocks
indefinitely, causing test timeouts (600s+).

Also use os.MkdirTemp instead of t.TempDir to avoid cleanup failures
when lumberjack still holds file handles.
This commit is contained in:
erio committed 2026-03-16 21:37:59 +08:00
1 parent 431c0e7236
commit ff9cb6c6c0
2 files changed
+15 -5

No files matched your search

@@ -77,7 +77,7 @@ func TestStdLogBridgeRoutesLevels(t *testing.T) {
log.Printf("service started")
log.Printf("Warning: queue full")
log.Printf("Forward request failed: timeout")
Sync()
// Skip Sync() — on Windows, fsync on pipes deadlocks (FlushFileBuffers).
_ = stdoutW.Close()
_ = stderrW.Close()
@@ -139,7 +139,7 @@ func TestLegacyPrintfRoutesLevels(t *testing.T) {
LegacyPrintf("service.test", "request started")
LegacyPrintf("service.test", "Warning: queue full")
LegacyPrintf("service.test", "forward failed: timeout")
Sync()
// Skip Sync() — on Windows, fsync on pipes deadlocks (FlushFileBuffers).
_ = stdoutW.Close()
_ = stderrW.Close()