github/codex
4
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-19 16:17:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the current badge from TUI task rows (#48776)

Browse Source 
Let task titles use the space previously reserved for the `current` badge
in the agents overview. Update the overview assertion and rendering
snapshots to match.

GitOrigin-RevId: 6a007d4f8b1a3a77459895725e2db8ef4a4d584d
This commit is contained in:
Eric Traut
2026-09-27 19:48:44 +00:00
committed by copyberry
parent 596f8c5c3c
commit 89bf86d0bd
5 changed files with 10 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/app/agent_center/rows.rs
+1 -11
View File
@@ -1,5 +1,5 @@
//! Grouped live tasks with shared identity colors and stable title, status and age columns.
//! Current-task labels and full titles share the flexible column; metadata drops at narrow widths.
//! Full titles use the flexible column; metadata drops at narrow widths.
//! The final cell stays blank inside the full-width selection highlight.
use super::navigation::CenterRow;
@@ -173,16 +173,6 @@ impl AgentsOverviewView {
buf,
);
let (mut title, status_area, updated) = columns(rect);
if task.is_current && title.width >= 14 {
let badge = Rect::new(
title.right() - 10,
title.y,
/*width*/ 10,
/*height*/ 1,
);
title.width -= 10;
line(Line::from(" current").style(style), badge, buf);
}
if task.has_voice && title.width >= 8 {
let badge = Rect::new(
title.right() - 8,
codex-rs/tui/src/app/agents_overview_tests.rs
+1 -1
View File
@@ -1311,7 +1311,7 @@ async fn shared_overview_shows_only_root_sessions() {
assert!(
rendered
.lines()
.any(|line| line.contains("› ● Inspect unnamed task") && line.contains("current"))
.any(|line| line.contains("› ● Inspect unnamed task"))
);
app.transcript_cells.push(std::sync::Arc::new(
codex-rs/tui/src/app/snapshots/codex_tui__app__agents_overview__tests__actions__hiding_tasks_keeps_selection_adjacent_in_display_order.snap
+6 -6
View File
@@ -5,21 +5,21 @@ expression: "selections.join(\"\\n\")"
Project, filtered=false: › ○ Task 3
Project, filtered=false: › ○ Task 4
Project, filtered=false: › ○ Other 2
Project, filtered=false: › ○ Task 1 current
Project, filtered=false: › ○ Task 1
Project, filtered=true: › ○ Task 3
Project, filtered=true: › ○ Task 4
Project, filtered=true: › ○ Task 1 current
Project, filtered=true: › ○ Task 1
Status, filtered=false: › ○ Task 3
Status, filtered=false: › ○ Other 2
Status, filtered=false: › ○ Task 1 current
Status, filtered=false: › ○ Task 1
Status, filtered=false: › ○ Task 4
Status, filtered=true: › ○ Task 3
Status, filtered=true: › ○ Task 1 current
Status, filtered=true: › ○ Task 1
Status, filtered=true: › ○ Task 4
Model, filtered=false: › ○ Task 3
Model, filtered=false: › ○ Task 4
Model, filtered=false: › ○ Other 2
Model, filtered=false: › ○ Task 1 current
Model, filtered=false: › ○ Task 1
Model, filtered=true: › ○ Task 3
Model, filtered=true: › ○ Task 4
Model, filtered=true: › ○ Task 1 current
Model, filtered=true: › ○ Task 1
codex-rs/tui/src/app/snapshots/codex_tui__app__agents_overview__tests__command_center__live_center_columns.snap
+1 -1
View File
@@ -7,7 +7,7 @@ expression: "screen(&view, 160, 22)"
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Tasks Status Updated │ Task details
/tmp/project 6 │
› ○ Current task current Ready now │ Current task
› ○ Current task Ready now │ Current task
○ A longer task title that uses the available column voice Ready 5m ago │ ○ Ready
! Failed task Error 1h ago │
● Needs an answer Needs input 2h ago │ Project
codex-rs/tui/src/snapshots/codex_tui__app__agents_overview__tests__agents_overview.snap
+1 -1
View File
@@ -7,7 +7,7 @@ expression: "render_bottom_popup(&app.chat_widget,\n96).replace(&format!(\"{proj
────────────────────────────────────────────────────────────────────────────────────────────
Tasks │ Task details
/tmp/project 3 │
› ● Build the dashboard current │ Build the dashboard
› ● Build the dashboard │ Build the dashboard
● Repair authentication │ ● Needs input
○ Review yesterday's changes │
│ Agent: Inspect keyboard shortcuts