github/codex
4
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-19 16:17:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move Windows sandbox tests into a dedicated integration binary (#51678)

Browse Source 
## Why

Elevated Windows sandbox tests share machine-wide accounts. Running them in the sharded core suite can consume test deadlines while shards wait for the account lock.

## What changed

Move the Windows sandbox tests into the Windows-only `windows_sandbox` integration-test binary. Update the nextest account-sharing group to select the entire binary instead of individual test names, so tests queue before their timeouts start. Keep the existing guard for coordination with other test binaries.

GitOrigin-RevId: 613925c9398b5acc8440fa34c658680f31f65c8b
This commit is contained in:
jif
2026-10-07 12:47:04 +00:00
committed by copyberry
parent b17c74cfd5
commit d83bb540ec
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/.config/nextest.toml
+1 -7
View File
@@ -90,13 +90,7 @@ test-group = 'core_apply_patch_cli_integration'
# starting their timeout; their file lock still coordinates other test processes.
platform = 'cfg(windows)'
filter = '''
(package(codex-core) & (
test(windows_sandbox_cli_preserves_managed_deny_reads_across_launches) |
test(windows_elevated_does_not_create_missing_workspace_metadata) |
test(windows_elevated_enforces_deny_read_and_protects_setup_marker) |
test(windows_elevated_unified_exec_enforces_large_recursive_deny_reads) |
test(windows_elevated_approved_git_pull_preserves_deny_read)
)) |
(package(codex-core) & binary(windows_sandbox)) |
(package(codex-exec-server) & test(file_system_elevated_relative_read_denial_uses_policy_cwd)) |
(package(codex-windows-sandbox) & test(elevated_non_tty_cmd_forwards_env_output_and_exit))
'''
codex-rs/core/tests/suite/mod.rs
-2
View File
@@ -251,8 +251,6 @@ mod web_search;
mod web_search_system_proxy;
mod websocket_fallback;
mod window_headers;
#[cfg(target_os = "windows")]
mod windows_sandbox;
mod workspace_roots;
mod worktree_trust;
codex-rs/core/tests/suite/windows_sandbox.rs → codex-rs/core/tests/windows_sandbox.rs
+9
View File
@@ -1,3 +1,12 @@
//! Exercises the Windows sandbox in a dedicated integration-test binary.
//!
//! Elevated cases share machine-wide accounts, so keep them out of the sharded
//! core suite: otherwise several shards spend their test deadlines waiting for
//! the account lock. The guard still coordinates with other test binaries.
#![cfg(target_os = "windows")]
#![allow(clippy::expect_used)]
use anyhow::Context;
use codex_config::types::ApprovalsReviewer;
use codex_core::TurnInputRequest;