github/codex
4
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-21 04:45:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Preserve Windows sandbox runner launch errors (#49261)

Browse Source 
## Why

Restoring the error mode with `SetErrorMode` can overwrite the failure code from `CreateProcessWithLogonW`, causing `RunnerLogonError` to report the wrong error.

## What changed

Capture `GetLastError()` immediately after a failed runner launch, before restoring the previous error mode, and use the saved code for `RunnerLogonError`.

GitOrigin-RevId: c0f4267232306be4d06e7e8accd60f7b77b8d6f3
This commit is contained in:
zm-oai
2026-09-29 13:09:03 +00:00
committed by copyberry
parent af0d68a236
commit f35a0fdc5d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/windows-sandbox-rs/src/elevated/runner_client.rs
+3 -2
View File
@@ -409,11 +409,12 @@ pub(crate) fn spawn_runner_transport(
&mut pi,
)
};
// Preserve the failure code before SetErrorMode can overwrite it.
let spawn_error = (spawn_res == 0).then(|| unsafe { GetLastError() });
unsafe {
SetErrorMode(previous_error_mode);
}
if spawn_res == 0 {
let err = unsafe { GetLastError() };
if let Some(err) = spawn_error {
return Err(RunnerLogonError { code: err }.into());
}
// Keep the process pinned through the entire startup handshake. Pipes close