github/dbx
4
0
Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-19 16:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(export): qualify PG foreign key schema and cascade table drops

Browse Source
This commit is contained in:
zipg
2026-09-15 17:35:03 +08:00
committed by GitHub
parent 62fab080e8
commit 571fc07d85
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/dbx-core/src/database_export.rs
+3 -2
View File
@@ -3801,7 +3801,8 @@ fn filter_export_table_infos(
}
fn drop_table_if_exists_sql(table_name: &str, schema: &str, db_type: &DatabaseType) -> String {
format!("DROP TABLE IF EXISTS {};", crate::transfer::qualified_table(table_name, schema, db_type, None))
let cascade = if db_type == &DatabaseType::Postgres { " CASCADE" } else { "" };
format!("DROP TABLE IF EXISTS {}{};", crate::transfer::qualified_table(table_name, schema, db_type, None), cascade)
}
fn build_database_export_object_source_sql(
@@ -4309,7 +4310,7 @@ mod tests {
fn builds_drop_table_if_exists_without_empty_schema() {
let sql = drop_table_if_exists_sql("users", "", &DatabaseType::Postgres);
assert_eq!(sql, "DROP TABLE IF EXISTS \"users\";");
assert_eq!(sql, "DROP TABLE IF EXISTS \"users\" CASCADE;");
}
#[test]
crates/dbx-core/src/schema.rs
+5 -2
View File
@@ -11239,7 +11239,7 @@ mod ddl_tests {
let ddl = render_postgres_table_ddl("public", "aaa_1", &columns, &[], &foreign_keys, None);
assert!(ddl.contains(
"CONSTRAINT \"aaa_1\" FOREIGN KEY (\"a\", \"b\", \"c\") REFERENCES \"aaa_2\"(\"a\", \"b\", \"c\")"
"CONSTRAINT \"aaa_1\" FOREIGN KEY (\"a\", \"b\", \"c\") REFERENCES \"public\".\"aaa_2\"(\"a\", \"b\", \"c\")"
));
assert_eq!(ddl.matches("CONSTRAINT \"aaa_1\" FOREIGN KEY").count(), 1);
}
@@ -12734,11 +12734,14 @@ fn render_postgres_table_ddl_with_constraints_and_partition_info(
}
let columns = fk_group.iter().map(|fk| pg_ident(&fk.column)).collect::<Vec<_>>().join(", ");
let ref_columns = fk_group.iter().map(|fk| pg_ident(&fk.ref_column)).collect::<Vec<_>>().join(", ");
let referenced_schema =
first_fk.ref_schema.as_deref().filter(|value| !value.trim().is_empty()).unwrap_or(schema);
let referenced_table = format!("{}.{}", pg_ident(referenced_schema), pg_ident(&first_fk.ref_table));
definition_lines.push(format!(
" CONSTRAINT {} FOREIGN KEY ({}) REFERENCES {}({})",
pg_ident(&first_fk.name),
columns,
pg_ident(&first_fk.ref_table),
referenced_table,
ref_columns
));
}