feat(editor): add clear-all action for sql parameter values

This commit is contained in:
jearhe
2026-08-28 14:25:42 +08:00
committed by GitHub
parent 17e2573fbe
commit 60bfb41f13
10 changed files with 123 additions and 0 deletions
@@ -86,6 +86,16 @@ function setAllParametersToRaw() {
values.value = next;
}
function clearParameterValues() {
const next = { ...values.value };
for (const parameter of props.parameters) {
const current = next[parameter.key] ?? { kind: "string", value: "" };
next[parameter.key] = { ...current, value: "" };
}
activeHistoryName.value = "";
values.value = next;
}
function updateValue(name: string, value: string) {
const matchedHistory = histories.value[name]?.find((entry) => entry.value === value);
values.value[name] = { ...(values.value[name] ?? { kind: "string" }), ...(matchedHistory ? { kind: matchedHistory.kind } : {}), value };
@@ -146,6 +156,9 @@ async function copyResolvedSql() {
<div class="grid max-h-[calc(86vh-8rem)] gap-4 overflow-y-auto pr-1">
<div class="flex flex-wrap items-center gap-2">
<p class="min-w-0 flex-1 text-sm text-muted-foreground">{{ t("sqlParameters.description") }}</p>
<Button type="button" size="sm" variant="outline" class="shrink-0" data-testid="sql-parameters-clear-values" @click="clearParameterValues">
{{ t("sqlParameters.clearValues") }}
</Button>
<Button type="button" size="sm" variant="outline" class="ml-auto shrink-0" data-testid="sql-parameters-use-raw-all" @click="setAllParametersToRaw">
{{ t("sqlParameters.useRawForAll") }}
</Button>
@@ -37,6 +37,14 @@ const MIXED_VALUES: Record<string, SqlParameterInput> = {
};
const RAW_VALUES = Object.fromEntries(Object.entries(MIXED_VALUES).map(([key, input]) => [key, { ...input, kind: "raw" as const }]));
const RAW_SQL = "SELECT alpha beta, 42, NULL, current_date, ${empty_value}, alpha beta";
const CLEARED_VALUES: Record<string, SqlParameterInput> = {
text_value: { kind: "string", value: "" },
numeric_value: { kind: "number", value: "" },
null_value: { kind: "null", value: "" },
raw_value: { kind: "raw", value: "" },
empty_value: { kind: "boolean", value: "" },
};
const CLEARED_SQL = "SELECT '', NULL, NULL, ${raw_value}, '', ''";
const mountedApps: App[] = [];
@@ -74,12 +82,22 @@ function actionButton(): HTMLButtonElement | null {
return document.body.querySelector('[data-testid="sql-parameters-use-raw-all"]');
}
function clearActionButton(): HTMLButtonElement | null {
return document.body.querySelector('[data-testid="sql-parameters-clear-values"]');
}
function clickRawAction() {
const button = actionButton();
expect(button).not.toBeNull();
button!.click();
}
function clickClearAction() {
const button = clearActionButton();
expect(button).not.toBeNull();
button!.click();
}
function buttonWithText(text: string): HTMLButtonElement | undefined {
return Array.from(document.body.querySelectorAll("button")).find((button) => button.textContent?.trim() === text);
}
@@ -164,3 +182,87 @@ describe("SqlParameterDialog raw parameter action", () => {
expect(state.open).toBe(false);
});
});
describe("SqlParameterDialog clear parameter values action", () => {
it("clears every displayed value while preserving kinds and updating the preview", async () => {
const { state, onExecute } = await mountDialog();
clickClearAction();
await nextTick();
expect(parameterInputs().map((input) => input.value)).toEqual(Array(PARAMETERS.length).fill(""));
expect(Array.from(document.body.querySelectorAll('[role="combobox"]')).map((trigger) => trigger.textContent?.trim())).toEqual(["String", "Number", "NULL", "Raw SQL", "Boolean"]);
expect(parameterInputs()[2]?.disabled).toBe(true);
expect(document.body.querySelector("pre")?.textContent).toBe(CLEARED_SQL);
expect(state.open).toBe(true);
expect(onExecute).not.toHaveBeenCalled();
expect(historyMocks.remember).not.toHaveBeenCalled();
});
it("preserves parameter history after clearing current values", async () => {
const { onExecute } = await mountDialog();
clickClearAction();
await nextTick();
const input = parameterInputs()[0];
expect(input).not.toBeUndefined();
input?.focus();
await nextTick();
await new Promise((resolve) => setTimeout(resolve, 0));
const historyEntry = Array.from(document.body.querySelectorAll("button")).find((button) => button.textContent?.includes("alpha beta"));
expect(historyEntry).toBeDefined();
historyEntry?.dispatchEvent(new MouseEvent("mousedown", { bubbles: true }));
await nextTick();
expect(parameterInputs()[0]?.value).toBe("alpha beta");
expect(onExecute).not.toHaveBeenCalled();
expect(historyMocks.remember).not.toHaveBeenCalled();
});
it("keeps cancel side-effect free after clearing values", async () => {
const { state, onExecute } = await mountDialog();
clickClearAction();
await nextTick();
buttonWithText("Cancel")?.click();
await nextTick();
expect(state.open).toBe(false);
expect(onExecute).not.toHaveBeenCalled();
expect(historyMocks.remember).not.toHaveBeenCalled();
});
it("remembers and emits cleared values only when Execute is clicked", async () => {
const { state, onExecute } = await mountDialog();
clickClearAction();
await nextTick();
expect(historyMocks.remember).not.toHaveBeenCalled();
buttonWithText("Execute")?.click();
await nextTick();
expect(historyMocks.remember).toHaveBeenCalledOnce();
expect(historyMocks.remember).toHaveBeenCalledWith(CLEARED_VALUES);
expect(onExecute).toHaveBeenCalledOnce();
expect(onExecute).toHaveBeenCalledWith(CLEARED_SQL);
expect(state.open).toBe(false);
});
it("is idempotent when the current parameter values are already empty", async () => {
const { state, onExecute } = await mountDialog(CLEARED_VALUES);
const beforePreview = document.body.querySelector("pre")?.textContent;
clickClearAction();
await nextTick();
expect(parameterInputs().map((input) => input.value)).toEqual(Array(PARAMETERS.length).fill(""));
expect(Array.from(document.body.querySelectorAll('[role="combobox"]')).map((trigger) => trigger.textContent?.trim())).toEqual(["String", "Number", "NULL", "Raw SQL", "Boolean"]);
expect(document.body.querySelector("pre")?.textContent).toBe(beforePreview);
expect(state.open).toBe(true);
expect(onExecute).not.toHaveBeenCalled();
expect(historyMocks.remember).not.toHaveBeenCalled();
});
});
+1
View File
@@ -5205,6 +5205,7 @@ export default {
collectionValuePlaceholder: "Enter a JSON array or comma-separated values",
preview: "SQL Preview",
execute: "Execute",
clearValues: "Clear Values",
useRawForAll: "Use Raw SQL for All",
kind: {
string: "String",
+1
View File
@@ -4951,6 +4951,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "Introduce un array JSON o valores separados por comas",
preview: "Vista previa SQL",
execute: "Ejecutar",
clearValues: "Borrar valores",
useRawForAll: "Usar SQL sin procesar para todos",
kind: {
string: "Cadena",
+1
View File
@@ -4949,6 +4949,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "Inserisci un array JSON o valori separati da virgole",
preview: "Anteprima SQL",
execute: "Esegui",
clearValues: "Cancella valori",
useRawForAll: "Usa SQL non elaborato per tutti",
kind: {
string: "Stringa",
+1
View File
@@ -4978,6 +4978,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "JSON 配列またはカンマ区切りの値を入力",
preview: "SQLプレビュー",
execute: "実行",
clearValues: "値をクリア",
useRawForAll: "すべてを生の SQL に設定",
kind: {
string: "文字列",
+1
View File
@@ -4634,6 +4634,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "JSON 배열 또는 쉼표로 구분된 값 입력",
preview: "SQL 미리보기",
execute: "실행",
clearValues: "값 지우기",
useRawForAll: "모두 원시 SQL로 설정",
kind: {
string: "문자열",
+1
View File
@@ -4951,6 +4951,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "Insira um array JSON ou valores separados por vírgula",
preview: "Prévia SQL",
execute: "Executar",
clearValues: "Limpar valores",
useRawForAll: "Usar SQL bruto para todos",
kind: {
string: "Texto",
+1
View File
@@ -5190,6 +5190,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "输入 JSON 数组或逗号分隔值",
preview: "SQL 预览",
execute: "执行",
clearValues: "清空参数值",
useRawForAll: "全部使用原始 SQL",
kind: {
string: "字符串",
+1
View File
@@ -4275,6 +4275,7 @@ export default withEnglishFallback({
collectionValuePlaceholder: "輸入 JSON 陣列或逗號分隔值",
preview: "SQL 預覽",
execute: "執行",
clearValues: "清空參數值",
useRawForAll: "全部使用原始 SQL",
kind: {
string: "字串",