github/dbx
4
0
Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-20 00:17:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(grid): stop double-escaping backslashes in oracle literals

Browse Source
This commit is contained in:
Melody Ruch
2026-09-20 19:09:56 +08:00
committed by GitHub
parent 6a5bfb6936
commit 99d2aa5f13
1 changed files with 35 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/dbx-sql/src/data_grid_sql.rs
+35 -1
View File
@@ -2472,7 +2472,9 @@ pub fn format_grid_sql_literal_with_identifier_quote(
}
let escaped_text = if database_type == Some(DatabaseType::Neo4j) {
literal_text.replace('\\', "\\\\").replace('\'', "\\'")
} else if is_sqlite_literal_database(database_type) || database_type == Some(DatabaseType::Dameng) {
} else if is_sqlite_literal_database(database_type)
|| matches!(database_type, Some(DatabaseType::Dameng | DatabaseType::Oracle))
{
// These engines keep backslashes literal in ordinary string literals,
// so only the quote delimiter needs escaping.
literal_text.replace('\'', "''")
@@ -7820,6 +7822,38 @@ mod tests {
);
}
#[test]
fn oracle_data_grid_writes_do_not_double_escape_backslashes() {
assert_eq!(format_grid_sql_literal(&json!(r"\n"), Some(DatabaseType::Oracle), None), r"'\n'");
assert_eq!(format_grid_sql_literal(&json!(r"line\n's"), Some(DatabaseType::Oracle), None), r"'line\n''s'");
let nested_json = r#"{"ext":"{\"v1\":\"123\",\"v3\":\"{\\\"vl1\\\":\\\"x\\\"}\"}"}"#;
let result = prepare_data_grid_save(DataGridSaveStatementOptions {
database_type: Some(DatabaseType::Oracle),
identifier_quote: None,
table_meta: DataGridTableMeta {
catalog: None,
database: None,
schema: Some("DBX_TEST".to_string()),
table_name: "DBX9708_JSON".to_string(),
primary_keys: vec!["ID".to_string()],
columns: Some(vec![column("ID", "NUMBER", false, None), column("VAL", "VARCHAR2(400)", true, None)]),
},
columns: vec!["ID".to_string(), "VAL".to_string()],
source_columns: None,
rows: vec![vec![json!(1), json!("old")]],
dirty_rows: vec![(0, vec![(1, json!(nested_json))])],
deleted_rows: vec![],
new_rows: vec![],
});
assert_eq!(result.validation_error, None);
assert_eq!(
result.statements,
vec![format!(r#"UPDATE "DBX_TEST"."DBX9708_JSON" SET "VAL" = '{nested_json}' WHERE "ID" = 1;"#)]
);
}
#[test]
fn sqlserver_literals_do_not_double_escape_backslashes() {
assert_eq!(format_grid_sql_literal(&json!(r".\SQL2016"), Some(DatabaseType::SqlServer), None), r"N'.\SQL2016'");