github/dbx
4
0
Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-21 08:13:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): split Doris range partition statements

Browse Source
This commit is contained in:
Eve
2026-09-09 23:53:03 +08:00
committed by GitHub
parent 619cd8f897
commit aca3faa762
2 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/desktop/src/lib/__tests__/sql/sqlStatementRanges.spec.ts
Vendored
+14
View File
@@ -1375,6 +1375,20 @@ FROM orders;`;
});
describe("executableStatementRanges", () => {
it.each(["doris", "starrocks"] as const)("keeps %s half-open range partitions from swallowing the next statement", (databaseType) => {
const first = `CREATE TABLE fixed_partitions_1 (
sale_date date NULL,
product_id int NULL
) ENGINE=OLAP
DUPLICATE KEY(sale_date, product_id)
PARTITION BY RANGE(sale_date) (
PARTITION p_2024_01 VALUES [('2024-02-01'), ('2024-03-01'))
)
DISTRIBUTED BY HASH(product_id) BUCKETS 1`;
const second = first.replace("fixed_partitions_1", "fixed_partitions_2");
expect(rangeSqlTexts(executableStatementRanges(`${first};\n\n${second};`, databaseType))).toEqual([first, second]);
});
it("returns statement ranges starting only at statement starts", () => {
const sql = "SELECT *\nFROM users\nWHERE active = 1;\nSELECT 2;";
const ranges = executableStatementRanges(sql);
apps/desktop/src/lib/sql/sqlStatementRanges.ts
+8 -4
View File
@@ -196,6 +196,10 @@ function splitElasticsearchRestRequestRanges(sql: string): RawStatement[] | unde
type QuoteState = "none" | "single" | "double" | "backtick" | "bracket" | "dollar";
function usesBracketIdentifierQuotes(databaseType?: DatabaseType): boolean {
return databaseType !== "doris" && databaseType !== "starrocks";
}
const COMMON_SOFT_STATEMENT_START_KEYWORDS = [
"SELECT",
"WITH",
@@ -564,7 +568,7 @@ export function splitSqlStatementRanges(sql: string, databaseType?: DatabaseType
i += 1;
continue;
}
if (ch === "[") {
if (ch === "[" && usesBracketIdentifierQuotes(databaseType)) {
markContent(i);
state = "bracket";
i += 1;
@@ -984,7 +988,7 @@ function topLevelSoftStatementLineStarts(sql: string, statement: RawStatement, d
i += 1;
continue;
}
if (ch === "[") {
if (ch === "[" && usesBracketIdentifierQuotes(databaseType)) {
state = "bracket";
i += 1;
continue;
@@ -1187,7 +1191,7 @@ function topLevelWordsBefore(sql: string, from: number, to: number, limit: numbe
i += 1;
continue;
}
if (ch === "[") {
if (ch === "[" && usesBracketIdentifierQuotes(databaseType)) {
state = "bracket";
i += 1;
continue;
@@ -1541,7 +1545,7 @@ function trimRangeEndBeforeNextBoundary(sql: string, from: number, nextBoundaryF
i += 1;
continue;
}
if (ch === "[") {
if (ch === "[" && usesBracketIdentifierQuotes(databaseType)) {
state = "bracket";
lastContentEnd = i + 1;
i += 1;