github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2026-10-21 13:24:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to fix ClassCastException in isToManyDirty() check

Browse Source
This commit is contained in:
Vladimir Konkov
2021-09-20 20:02:58 +03:00
parent b450227b13
commit 01e7ddcffd
2 changed files with 35 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
+2 -2
View File
@@ -2875,8 +2875,8 @@ public class BeanDescriptor<T> implements BeanType<T>, STreeType, SpiBeanType {
final EntityBeanIntercept ebi = bean._ebean_getIntercept();
for (BeanPropertyAssocMany<?> many : propertiesManySave) {
if (ebi.isLoadedProperty(many.propertyIndex())) {
final BeanCollection<?> value = (BeanCollection<?>) many.getValue(bean);
if (value != null && value.hasModifications()) {
final Object value = many.getValue(bean);
if (value instanceof BeanCollection && ((BeanCollection<?>)value).hasModifications() || value != null) {
return true;
}
}
ebean-test/src/test/java/org/tests/transparentpersist/TestTransparentPersist.java
+33
View File
@@ -13,6 +13,7 @@ import org.tests.model.basic.EBasicVer;
import org.tests.model.basic.Order;
import org.tests.model.basic.OrderShipment;
import java.util.ArrayList;
import java.util.List;
import static org.assertj.core.api.Assertions.assertThat;
@@ -176,6 +177,38 @@ public class TestTransparentPersist extends BaseTestCase {
DB.delete(Customer.class, c0.getId());
}
@Test
public void insertWithPersistCascadeInsert() {
// setup data
Customer c0 = new Customer();
c0.setName("firstCust");
DB.save(c0);
Integer orderId;
try (Transaction transaction = DB.beginTransaction()) {
transaction.setAutoPersistUpdates(true); // EXPERIMENTAL feature
Order order = new Order();
order.setStatus(Order.Status.NEW);
order.setCustomer(c0);
order.setShipments(new ArrayList<>());
DB.insert(order);
orderId = order.getId();
// cascade persist will insert this Shipment (even though it isn't in the persistence context)
OrderShipment osh0 = new OrderShipment();
order.addShipment(osh0);
transaction.commit();
}
Order checkOrder = DB.find(Order.class, orderId);
assertThat(checkOrder.getStatus()).isEqualTo(Order.Status.NEW);
assertThat(checkOrder.getShipments().size()).isEqualTo(1);
DB.delete(checkOrder);
DB.delete(Customer.class, c0.getId());
}
@Test
public void updateReferenceOnlyWithPersistCascade_Insert_andUpdateForeignKey() {