For experimental "transparent persistence" - Inserts added to PC

When inserting bean with transparent persistence the beans are registered with the persistence context. This is done to support the cases where the beans are inserted, a flush() occurs, the inserted bean is mutated and now dirty - we want that to be detected and get an update

ebean-core/src/main/java/io/ebeaninternal/api/ScopedTransaction.java

@@ -131,11 +131,6 @@ public class ScopedTransaction extends SpiTransactionProxy {
     }
   }
 
-  @Override
-  public void setTransparentPersistence(boolean transparentPersistence) {
-    current.getTransaction().setTransparentPersistence(transparentPersistence);
-  }
-
   @Override
   public void setRollbackOnly() {
     current.setRollbackOnly();

ebean-core/src/main/java/io/ebeaninternal/api/SpiTransaction.java

@@ -147,6 +147,11 @@ public interface SpiTransaction extends Transaction {
    */
   int depth();
 
+  /**
+   * Return true if transparent persistence is turned on.
+   */
+  boolean isTransparentPersistence();
+
   /**
    * Return true if this transaction was created explicitly via
    * <code>Ebean.beginTransaction()</code>.

ebean-core/src/main/java/io/ebeaninternal/api/SpiTransactionProxy.java

@@ -43,6 +43,16 @@ public abstract class SpiTransactionProxy implements SpiTransaction {
     return transaction.getLabel();
   }
 
+  @Override
+  public void setTransparentPersistence(boolean transparentPersistence) {
+    transaction.setTransparentPersistence(transparentPersistence);
+  }
+
+  @Override
+  public boolean isTransparentPersistence() {
+    return transaction.isTransparentPersistence();
+  }
+
   @Override
   public void commitAndContinue() {
     transaction.commitAndContinue();

ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java

@@ -1038,6 +1038,10 @@ public final class PersistRequestBean<T> extends PersistRequest implements BeanP
     if (!publish) {
       beanDescriptor.setDraft(entityBean);
     }
+    if (transaction.isTransparentPersistence() && idValue != null) {
+      // with getGeneratedKeys off we will not have a idValue
+      beanDescriptor.contextPut(transaction.getPersistenceContext(), idValue, entityBean);
+    }
   }
 
   public boolean isReference() {

ebean-core/src/main/java/io/ebeaninternal/server/transaction/ImplicitReadOnlyTransaction.java

@@ -100,6 +100,11 @@ class ImplicitReadOnlyTransaction implements SpiTransaction, TxnProfileEventCode
     // do nothing
   }
 
+  @Override
+  public boolean isTransparentPersistence() {
+    return false;
+  }
+
   @Override
   public void setLabel(String label) {
     // do nothing

ebean-core/src/main/java/io/ebeaninternal/server/transaction/JdbcTransaction.java

@@ -302,6 +302,11 @@ class JdbcTransaction implements SpiTransaction, TxnProfileEventCodes {
     this.batchMode = true;
   }
 
+  @Override
+  public boolean isTransparentPersistence() {
+    return transparentPersistence;
+  }
+
   @Override
   public boolean isSkipCacheExplicit() {
     return (skipCache != null && !skipCache);

ebean-core/src/main/java/io/ebeaninternal/server/transaction/NoTransaction.java

@@ -30,6 +30,11 @@ class NoTransaction implements SpiTransaction {
     // do nothing
   }
 
+  @Override
+  public boolean isTransparentPersistence() {
+    return false;
+  }
+
   @Override
   public void setLabel(String label) {
     // do nothing

ebean-core/src/main/java/io/ebeaninternal/server/transaction/SavepointTransaction.java

@@ -60,11 +60,6 @@ class SavepointTransaction extends SpiTransactionProxy {
     this.rollbackOnly = true;
   }
 
-  @Override
-  public void setTransparentPersistence(boolean transparentPersistence) {
-    throw new IllegalStateException("This is not handled yet. Need to review this case.");
-  }
-
   @Override
   public void commit() {
     if (rollbackOnly) {

ebean-core/src/test/java/org/tests/transparentpersist/TestTransparentPersist.java

@@ -17,6 +17,42 @@ import static org.assertj.core.api.Assertions.assertThat;
 
 public class TestTransparentPersist extends BaseTestCase {
 
+  @Test
+  public void insertFlush_mutateFlush_expect_update() {
+
+    LoggedSql.start();
+
+    EBasicVer newBean;
+    try (Transaction transaction = DB.beginTransaction()) {
+      transaction.setTransparentPersistence(true); // EXPERIMENTAL feature
+
+      newBean = new EBasicVer("insertMe");
+      DB.save(newBean);
+
+      // flush - new bean needs to get registered into persistence context
+      transaction.flush();
+
+      // make it dirty, we expect it to execute an update on flush()
+      newBean.setName("make it dirty - auto save");
+
+      // flush again, auto persist dirty bean in persistence context
+      transaction.commit();
+    }
+
+    List<String> sql = LoggedSql.stop();
+
+    EBasicVer found = DB.find(EBasicVer.class, newBean.getId());
+    assertThat(found.getName()).isEqualTo("make it dirty - auto save");
+
+    assertThat(sql).hasSize(4);
+    assertThat(sql.get(0)).contains("insert into e_basicver");
+    assertThat(sql.get(1)).contains(" -- bind(");
+    assertThat(sql.get(2)).contains("update e_basicver set name=?, last_update=? where id=? and last_update=?");
+    assertThat(sql.get(3)).contains(" -- bind(");
+
+    DB.delete(found);
+  }
+
   @Test
   public void delete_expect_beanRemovedFromPersistenceContext() {