#2575 Tidy up for [DDL-ClickHouse] fixes for ClickHouse platform

ebean-core/src/main/java/io/ebeaninternal/server/core/DScriptRunner.java

@@ -107,7 +107,6 @@ final class DScriptRunner implements ScriptRunner {
         DdlRunner runner = new DdlRunner(useAutoCommit, scriptName, platformName);
         runner.runAll(content, connection);
         if (!connection.getAutoCommit()) {
-          // Clickhouse fails: Cannot commit when auto-commit is enabled
           connection.commit();
         }
         runner.runNonTransactional(connection);

ebean-test/src/test/resources/migrationtest/dbmigration/clickhouse/1.1.sql

@@ -48,8 +48,8 @@ alter table migtest_e_basic alter column status2 drop default;
 alter table migtest_e_basic alter column status2 set null;
 alter table migtest_e_basic alter column user_id set null;
 alter table migtest_e_basic add column new_string_field String default 'foo''bar';
-alter table migtest_e_basic add column new_boolean_field UInt8 default true;
-alter table migtest_e_basic add column new_boolean_field2 UInt8 default true;
+alter table migtest_e_basic add column new_boolean_field UInt8 default 1;
+alter table migtest_e_basic add column new_boolean_field2 UInt8 default 1;
 alter table migtest_e_basic add column progress UInt32 default 0;
 alter table migtest_e_basic add column new_integer UInt32 default 42;
 alter table migtest_e_history alter column test_string UInt64;
@@ -59,11 +59,11 @@ alter table migtest_e_history2 add column test_string2 String;
 alter table migtest_e_history2 add column test_string3 String default 'unknown';
 alter table migtest_e_history2 add column new_column String;
 alter table migtest_e_history4 alter column test_number UInt64;
-alter table migtest_e_history5 add column test_boolean UInt8 default false;
+alter table migtest_e_history5 add column test_boolean UInt8 default 0;
 alter table migtest_e_history6 alter column test_number1 set default 42;
 alter table migtest_e_history6 alter column test_number1 set not null;
 alter table migtest_e_history6 alter column test_number2 set null;
-alter table migtest_e_softdelete add column deleted UInt8 default false;
+alter table migtest_e_softdelete add column deleted UInt8 default 0;
 alter table migtest_oto_child add column master_id UInt64;
 -- apply post alter
 alter table migtest_e_basic add constraint ck_migtest_e_basic_status check ( status in ('N','A','I','?'));

ebean-test/src/test/resources/migrationtest/dbmigration/clickhouse/idx_clickhouse.migrations

@@ -1,6 +1,6 @@
--697238714,     1.0__initial.sql
--1523257380,    1.1.sql
+1588846231,     1.0__initial.sql
+-1102375855,    1.1.sql
 1279151426,     1.2__dropsFor_1.1.sql
-14388492,       1.3.sql
+581928632,      1.3.sql
 80209848,       1.4__dropsFor_1.3.sql