It is difficult to maintain one build system, let alone two - especially
if one build system is known to be better maintained and the other build
system continues to be used - with bug and feature requests raised
against it.
The maintainers are aware that there are people using the CMake system,
but believe that the extra maintainability of only having one build
system, combined with the knowledge that the current CI system
demonstrates that all supported architectures are working with the
Makefiles make the use of these Makefiles a more sustainable direction.
* Refactor traceEvent to allow variable log levels
* Refactor sendto failed for less repetition
* Refactor sendto_fd to make control flow clearer, also reduce repetition
* Tie size to the actual object not its class
* Show destination that had issues when sendto_fd fails
* Fix MSVC compile - it doesnt support the same variadic macros as gcc
* Fix cmake informational log messages
* If the correct library name is used find_library works better
* Re-enable remaining find_library users
* Reorder cmake to make libpcap detection work
For a moment there, I was starting to think that I might have found
a good feature in cmake, but then it turned out that it had specific
ordering requirements and strange cryptic functions that error out
in mysterious ways.
If I am going to have an antique build engine with special quirks that
I must learn in order to use it, I may as well choose the one that is
not also trying to be clever and hiding its internal magic from me.
Which means that I still prefer Makefiles - they are more debuggable.
* Ensure all options start off for cmake too
* Attempt to make the build time config logic in the cmake process match the makefile process
* Add a simple muscle memory helper for cmake
* Ask them what they are smoking, then tell them to put it out
* Avoid occasional stale package cache errors
* Convert zstd feature to default disable
* All autoconf test use one standard template
To simplify the testing, cross-compilation and repeatable build process,
no configure options are automatically probed for - they all default to
off and are all using the same template.
The --with-x options should be deprecated and replaced with --enable-x
because there is no syntax checking for --with options in autoconf.
There are still some differences between the config options, but this
should provide a starting point.
* Remove unused code from the autoconf
* Remove warnings from default build
* Avoid calling port mapping functions if none are enabled
* Start with all builds in neutral config
* Add more missing code guards
* Adjust code guard location to placate cmake
* First attempt at a openwrt CI
* Fix action - helps if I dont forget the syntax half way through writing it
* Try building /this/ branch for the openwrt CI
* Try a build with openssl configured
* Dont enable the n2n package until we have built the environment - makes errors easier to see and clearly related to n2n
* Attempt to speed up the openwrt build
* Upload any created ipkg packages
* Dont test with openssl for the moment
* Attempt to speed up openwrt build using a cache of the build dir
* The make defconfig run turns all the built binaries stale, so stop caching them. Also use a real ref for the cache key
* Minor text name changes
* Address yamllint concerns
* Attempt to simplify and document missing parts of the openwrt makefile
* Attempt to fix mystery openwrt make error
* Rename build job name
* Avoid nested checkouts, use two separate dirs for the two checkouts in this build
* Move the n2n checkout to earler, allowing us to skip one defconfig run
* We are going to need working tags from the n2n repo, so ensure we unbreak the github checkout braindamage
* Calculate and save the n2n version string
* Prepare the way to pass the correct external vars into the openwrt build
* Hook calculated build variables into the openwrt package definition
* Update artifacts source to match moved checkout dir
* Pass env vars in to the make
* Allow version script to be influenced by external vars
* It will help if I use the same variable names everywhere
* Add more version variable calculation overrides
* Configure openwrt to use the external git checkout instead of their create-tar-then-extract dance
* Using the correct syntax for ifdef will help significantly
* Use as many jobs as we have cpus
* As the USE_SOURCE_DIR option allows us to use a full git checkout, we do not need to hack the version.sh to allow overrides
* Ensure scripts/version.sh works from anywhere
* Remove unneeded variables
* Update openwrt build documentation to match the new build process
* Catch failure to cd as per shellcheck suggestion
* Limit lengthy openwrt builds to manual triggers or on a release
* Also run on specially named branches
* Break list into separate lines for easier future editing
* Make it clear which hash we are testing
* Coverage for all pearson hash variants
* Initial coverage for auth.c
* Add some more auth.c coverage
* Ensure new bins are added to both build systems
* Ensure new source files are fully linted
We aim to always build with the full version number from the git
checkout, however if the current build is not being made from a git
repository, we need to fallback to using the version number from
the "VERSION" file.
This patch changes the choice of the fallback path from just assuming
that any git repo is our git repo to explicitly looking for a `.git` dir
in the top of our checkout.
Some integrated build systems end up doing a tar extract of the n2n
source code inside their build-system git repo, and the old fallback
check was failing in that case.
We still need to identify these build systems and work out a way to
provide them with the full and correct version number for their build,
but this patch should make things more reliable until then.
Hamish Coleman