Commit Graph
8 Commits
Author SHA1 Message Date
Saverio Miroddi b2f7e7ece5 hbb_common: Fix CONFIG locks unintentionally not acquired
Variables defined as `_` only are released immediately; see compile error:

    error: non-binding let on a synchronization lock
      --> libs/hbb_common/src/config.rs:798:13
        |
    798 |         let _ = CONFIG.read().unwrap(); // for lock
        |             ^   ^^^^^^^^^^^^^^^^^^^^^^ this binding will immediately drop the value assigned to it
        |             |
        |             this lock is not assigned to a binding and is immediately dropped
        |
        = note: `#[deny(let_underscore_lock)]` on by default

By appending a phony suffix to the variable name, the lock stays in scope.
2022-11-01 15:08:21 +01:00
Saverio Miroddi ba5321c4a0 Strip release binary via Rust toolchain
As of Rust 1.59, full stripping support has been added (see https://blog.rust-lang.org/2022/02/24/Rust-1.59.0.html#creating-stripped-binaries).
2022-05-24 19:37:01 +02:00
Saverio Miroddi 34f5aa303b Add pynput installation section to README
Prevents flooding the server log with warnings.

Closes #591.
2022-05-24 19:30:56 +02:00
Saverio Miroddi 230f74da2e Remove IS_IN unsafe code, by using AtomicBool 2022-05-24 18:37:24 +02:00
Saverio Miroddi 0c0051d59a Remove SERVER_FILE_TRANSFER_ENABLED unsafe code, by using AtomicBool 2022-05-24 18:37:22 +02:00
Saverio Miroddi 45bb271c88 Remove SERVER_KEYBOARD_ENABLED unsafe code, by using AtomicBool 2022-05-24 18:12:42 +02:00
Saverio Miroddi c7f452752d Remove SERVER_CLIPBOARD_ENABLED unsafe code, by using AtomicBool 2022-05-24 18:12:33 +02:00
Saverio Miroddi 7f50fe3ea0 Remove KEYBOARD_HOOKED unsafe code, by using AtomicBool
For supported types, static R/W globals unsafe code can be replaced by safe `Atomic*` types.

The pattern of usage is simple:

- AtomicBool#swap is used to fetch the old `KEYBOARD_HOOKED` value, while setting it to true;
- if the old value was true, there is effectively no change to `KEYBOARD_HOOKED`, and the flow exits from the enclosing function;
- if the old value was false, execute the function (the new `KEYBOARD_HOOKED` has been set to true by swap()).

The most conservative ordering is used, as the context is not performance-sensitive.

Atomics are not supported on every platform, but the project assumes x86-64, which supports them.
2022-05-22 18:48:08 +02:00