Variables defined as `_` only are released immediately; see compile error:
error: non-binding let on a synchronization lock
--> libs/hbb_common/src/config.rs:798:13
|
798 | let _ = CONFIG.read().unwrap(); // for lock
| ^ ^^^^^^^^^^^^^^^^^^^^^^ this binding will immediately drop the value assigned to it
| |
| this lock is not assigned to a binding and is immediately dropped
|
= note: `#[deny(let_underscore_lock)]` on by default
By appending a phony suffix to the variable name, the lock stays in scope.
For supported types, static R/W globals unsafe code can be replaced by safe `Atomic*` types.
The pattern of usage is simple:
- AtomicBool#swap is used to fetch the old `KEYBOARD_HOOKED` value, while setting it to true;
- if the old value was true, there is effectively no change to `KEYBOARD_HOOKED`, and the flow exits from the enclosing function;
- if the old value was false, execute the function (the new `KEYBOARD_HOOKED` has been set to true by swap()).
The most conservative ordering is used, as the context is not performance-sensitive.
Atomics are not supported on every platform, but the project assumes x86-64, which supports them.