mirror of
https://github.com/rustdesk/rustdesk.git
synced 2026-10-20 00:17:55 +00:00
* fix web break introduced in 38f130071 fix(linux): enable mouse side buttons in remote sessions (#14848)
* feat(shortcuts): user-configurable keyboard shortcuts for session actions
Adds a keyboard shortcut feature (Rust matcher + Dart UI + cross-language
parity tests) that lets users bind combinations like Ctrl+Alt+Shift+P to
session actions. Bindings are stored in LocalConfig under
`keyboard-shortcuts`; the matcher gates dispatch on `enabled` and
`pass_through` flags so flipping the master switch off is a hard stop.
Wire-up summary:
- src/keyboard/shortcuts.rs: matcher, default bindings, parity test against
flutter/test/fixtures/default_keyboard_shortcuts.json
- src/keyboard.rs: shortcut intercept in process_event{,_with_session},
feature-gated to `flutter`; runs before key swapping so users bind to
physical keys
- src/flutter_ffi.rs: main_reload_keyboard_shortcuts +
main_get_default_keyboard_shortcuts; reload_from_config seeded in main_init
- flutter/lib/common/widgets/keyboard_shortcuts/: shared config page body,
recording dialog, shortcut display formatter, action group registry
- flutter/lib/desktop/pages/desktop_keyboard_shortcuts_page.dart and
flutter/lib/mobile/pages/mobile_keyboard_shortcuts_page.dart: platform
shells around the shared body
- flutter/lib/models/shortcut_model.dart: per-session ShortcutModel +
registerSessionShortcutActions for actions with no toolbar TToggleMenu /
TRadioMenu (fullscreen, switch display/tab, close tab, voice call, etc.)
- flutter/lib/common/widgets/toolbar.dart: optional `actionId` field on
TToggleMenu / TRadioMenu, plus per-helper auto-register pass that wires
tagged entries' existing onChanged into the ShortcutModel
- flutter/test/keyboard_shortcuts_test.dart + fixtures: cross-language
parity (default bindings, supported key vocabulary)
Design principles applied during review:
1. Additions are fine; modifications to original logic must be deliberate.
Tagging an existing TToggleMenu entry with `actionId:` is an addition.
Rewriting its onChanged to satisfy a new contract is a modification —
and was reverted for every case where the original click behavior was
working. Four closures were touched and then reverted (mobile View
Mode, Privacy mode multi-impl, Relative mouse mode, Reverse mouse
wheel); their shortcuts are wired via standalone closures in
shortcut_model.dart instead.
2. Toolbar auto-register is reserved for entries whose onChanged is
inherently self-flipping — typically `sessionToggleOption(name)` where
the named option is flipped in place and the input bool is unused. The
register pass passes `!menu.value` from registration time, which is
harmless under self-flipping but wrong for closures that consume the
input bool directly. Tagging a non-self-flipping entry forces a closure
rewrite; choose non-toolbar registration in that case.
3. When shortcuts are disabled, toolbar behavior must be bit-for-bit
unchanged. The matcher's `enabled`-gate already guarantees no
dispatch; the auto-register pass is left unconditional (its only effect
is HashMap operations on a separate ShortcutModel) so mid-session
enable works without a reconnect. The trade-off is intentional and
documented at the top of toolbarControls.
4. Comments stay terse. Rationale lives in one place — the doc comment of
the helper or registration site, not duplicated at every call site.
5. Where an existing helper needs a new optional behavior (e.g.
`_OptionCheckBox` gaining a tooltip slot), the new branch must reduce
to byte-identical output for existing callers (`trailing == null`
case → original `Expanded(Text)` layout). Verified.
6. Action IDs and labels stay consistent. Renamed `reset_cursor` →
`reset_canvas` so the action ID matches its user-facing label
("Reset canvas") and capability flag.
Out-of-scope but included:
- AGENTS.md: documents flutter_rust_bridge no-codegen workflow and the
Web target's hand-written TS client, since both are load-bearing for
any new FFI work.
- remote_toolbar.dart: i18n fix for the per-monitor tooltip ("All
monitors" / "Monitor #N"), unrelated to shortcuts but kept here.
* langs
* fix(keyboard): shortcuts, harden config and callback lifecycle
Signed-off-by: fufesou <linlong1266@gmail.com>
* feat(keyboard): shortcuts, color of "Reset to defaults"
Signed-off-by: fufesou <linlong1266@gmail.com>
* feat(keyboard): shortcuts, release keys before shortcut callback
Signed-off-by: fufesou <linlong1266@gmail.com>
* feat(keyboard): shortcuts, debug web
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(keyboard): iPad, icon
Signed-off-by: fufesou <linlong1266@gmail.com>
* langs: add shortcut keys to az, gl, ur
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, keep local modifiers and release keys on the right session
When a chord fired, the shortcut path reused release_remote_keys(), which
replays synthetic releases through process_event(). That cleared the local
MODIFIERS_STATE while the user still held the modifiers, so the next key of
a held chord no longer matched and leaked to the remote, and it sent the
releases to the globally current session instead of the one that typed the
chord.
The shortcut path now releases the remote keys itself: it sends through the
caller's session, and restores the modifiers it released on the remote as
still held locally. The press that fired is remembered until its release,
so its auto repeats and its release are consumed instead of reaching the
remote.
Also state the contract for unavailable actions: a bound chord always
belongs to RustDesk and is a no-op when the session has no handler.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, record the physical key
The recording dialog and the Web Flutter matcher named keys by
LogicalKeyboardKey, while the native matcher sees the physical key through
its USB HID usage and the Web JS matcher through KeyboardEvent.code. On
AZERTY, QWERTZ, Dvorak and similar layouts a recorded binding then did not
fire, or fired from another key.
Name keys by their physical position everywhere: physicalKeyName maps the
USB HID usage to the stored name. A new fixture pins every name to its USB
HID usage, checked on the Dart side and against rdev::usb_hid_key_from_code
on the Rust side, and a test covers AZERTY and QWERTZ events.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, keep an empty binding list on re-enable
setEnabled seeded the defaults whenever the binding list was empty, so a
user who cleared every binding got all defaults back after disable and
enable. Seed only when the config has never held a bindings list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, track every fired key until its release
FIRED_KEY held a single key, so overlapping shortcut keys broke it: with the
chord held, P then C overwrote P, P's release reached the remote, and a P
repeat could fire the screenshot again. A repeat after the modifiers were
released was also treated as a new press and leaked to the remote.
Keep a set of fired keys instead. Once a press fires, every event of that
key belongs to RustDesk until its release: repeats are consumed without
dispatching, whatever the modifiers do, and the release removes the key.
Entries whose release never arrives are dropped when a session view is
entered or a session is closed, not by guessing from the modifiers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, keep fired keys per session
FIRED_KEYS was process-global while dispatch is per session. Closing or
entering any session cleared the fired keys of all of them, so a key still
held in another session leaked its release to that remote, and a key fired
in one session made the same key in another session look like a repeat.
Key the fired set by session: try_dispatch resolves the session first and
only looks at that session's keys, and session_close clears only the
closing session. Entering a session view no longer clears anything: it is
a pointer enter, and a fired key may still be physically held across it.
A key whose release is missed otherwise heals itself: its next press is
consumed as a repeat and that release removes it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(shortcuts): preserve input state and refresh action availability
* fix(keyboard): shortcuts, keep a fired key owned across session close
Close tab is itself a shortcut, so the session that consumed the key press
is gone before the key is released. Both matchers dropped the key with the
session: the Flutter dispatcher removed its own entries in clear(), and the
Rust set was keyed by session and cleared in session_close. The release,
and the repeats while the key stayed held, then reached the next session's
remote as ordinary input.
Ownership of a fired key is physical, so it is now one set shared by every
session on each side, and closing a session no longer touches it: clear()
only drops the pending action and modifier replay, and the Rust session
state only tracks released modifiers. A key whose release is missed heals
itself on its next press. Entering view-only with the Flutter input source
still clears the Rust set, since that source stops routing key events to it.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, drop the Toggle Input Source action
The action switches the key capture backend between key down and key up.
Fired-key ownership lives in whichever matcher saw the press, the Flutter
dispatcher or the Rust set, and there is no handoff between them: after the
switch the repeats and the release of the held key reach the other backend,
which forwards them to the remote and, while the chord is held, matches the
action again and toggles the source back. Remove the shortcut instead of
building a handoff for one action. The toolbar radio menu is unchanged.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* perf(keyboard): shortcuts, parse the config once per stored value
The Flutter matcher read the local config three times and parsed its JSON
three times on every key press in legacy mode, on Web and in view-only.
Keep one parsed snapshot keyed by the raw stored string, so a key press
costs one config read and no parsing while the config is unchanged. The
existing readers are thin views of the same snapshot.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix(keyboard): shortcuts, run focus-changing actions on key release
Close tab and tab switching move keyboard focus to another session before
the key that fired them is released. On Linux the Flutter input source
routes map-mode sessions through the Rust matcher and legacy-mode sessions
through the Dart matcher, and neither knows the other's fired keys, so
after such an action the repeats and the release of the held key reached
the next session's remote, and the key stayed recorded as fired in the
matcher that saw the press.
Routing Linux legacy mode through the Rust FFI path instead is not a drop-in
change: the raw key handler builds its event with no unicode, so Rust's
legacy mode would fall back to US key names and lose the layout-aware
characters the Dart path sends today, and it would take modifiers from the
X11 key state instead of Flutter's.
Run these three actions when the fired key is released. The matcher that
consumed the press then also sees the repeats and the release, the remote
modifiers are still released on the press, and a session that closes drops
the action it owed. Both matchers keep the same list of actions.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* test(keyboard): shortcuts, pin the key-up action list on both sides
kShortcutActionsRunOnKeyUp and runs_on_release are two hand-kept lists of
the actions that run on key release. Add a shared fixture and check each
side against it, the way the key vocabulary and the default bindings are
already checked, so adding a focus-changing action on one side breaks a
test until the other side follows. The Dart test also checks that every
listed id is a configurable action.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ra4my61t8q1FN5n59wB16D
* fix: prevent lost input after remote session shortcuts
Avoid synthetic Alt presses that activate the Windows system menu
and swallow the next character.
Trigger restart, switch-sides, and chat actions on key release so
focus changes cannot leave subsequent shortcut presses ignored.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(mobile): correct Chat keyboard and input helper behavior
- Keep soft keyboard and helper hidden when Chat opens via shortcut
- Restore soft input on touch and remote focus after Chat closes
- Handle modifier releases while Chat owns focus
- Clear hidden virtual modifiers while preserving held keys and Pin behavior
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): prevent recording non-simultaneous key combinations
Build new captures from currently held keys instead of reusing released
letters. Preserve the last valid chord after release so it can be saved.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): isolate window actions and prevent duplicate Alt presses
- Dispatch shortcut actions only to the originating session window.
- Clear local modifier state on focus loss without resending modifiers
already released to Windows peers, preventing lost following input.
- Strengthen the regression assertion against extra Alt keydown events
Signed-off-by: fufesou <linlong1266@gmail.com>
* refact(shortcuts): empty default shortcuts for Cmd+Option+Shift+Del on macOS and iOS
Because Del may be ambiguous for new macOS users.
Cmd+Option+Shift+Backspace is "Empty Trash without confirmation" shortcut on macOS.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: use session peer platform for Ctrl+Alt+Del events
Fix Android-to-Linux Ctrl+Alt+Del delivery by using the session's peer
platform instead of the desktop global session, which defaults to Windows
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: hide relative mouse mode shortcuts on Wayland
Separate relative mouse mode availability from screenshot support.
Filter unsupported actions and defaults while preserving saved bindings
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: align shortcut availability with platform support
- Hide unsupported mobile and web shortcut actions
- Enable mobile scaling and Android voice call shortcuts
- Use openMonitorInTheSameTab() for display switching
- Preserve cursor position when switching displays on desktop and web
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: prevent held-key shortcut recording bypass
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: preserve keyboard input after shortcut dialogs
Run native clipboard shortcuts on key release and wait for remote modifier releases before dispatching.
Release remote modifiers when mobile local UI takes focus, and document the tested iPad Bluetooth Mute shortcut limitation.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: preserve remote key state during local shortcuts
Keep unrelated held keys pressed for session actions that retain input. Preserve key release when focus or input handling changes, and avoid synthetic Alt taps during shortcut dispatch.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: suspend saved relative mouse shortcuts on Wayland
Filter the native active binding cache without changing stored configuration, so the binding becomes available again under X11.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: exclude unsupported Wayland shortcuts from Flutter matching
Keep saved bindings intact while filtering the active config used by the Flutter matcher. Cover stored bindings and enable/pass-through flags in the existing shortcut tests.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: retain forwarded key ownership across shortcut repeats
Ignore repeat presses for keys already forwarded to the peer, and release ordinary held keys before Show My Cursor enables view-only. Cover both paths with converter-level regressions.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: release Flutter-held keys before view-only shortcuts
Track ordinary keys forwarded by the Dart matcher paths and await their releases before View Only or Show My Cursor disables input. Keep Mute key ownership and existing empty-cleanup timing unchanged.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: filter active Flutter shortcuts by platform capabilities
Reuse the Settings action filter for saved bindings while preserving storage, default-seeding behavior and configurable Apple Ctrl+Alt+Del bindings.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: filter native shortcut caches for mobile controllers
Suspend saved desktop-only actions on Android and iOS and hide unavailable iOS actions without changing persisted bindings. Keep native cache filtering aligned with Flutter platform capabilities.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: share filtered shortcut bindings with the Web matcher
Pass the active platform config to JavaScript at startup and after settings changes, preserving unsupported saved bindings in local storage.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: release Flutter-held keys before focus-changing shortcuts
Drain ordinary keys owned by the original session before run-on-key-up
actions and native clipboard callbacks. Preserve Mute holds, pending-action
cancellation and Web clipboard key-down activation.
Document the required Web matcher counterpart in the bridge:
rustdesk/rustdesk-web-js@94abe431d6
Validation: 61 native Flutter tests, 32 Chrome/HTML tests, targeted analysis
and Windows debug build.
Signed-off-by: fufesou <linlong1266@gmail.com>
* refact: remove the useless comments
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: prevent Windows menu activation from Alt-only shortcuts
Neutralize the forwarded Alt with a balanced temporary Ctrl press when a consumed local shortcut releases its only modifier in Windows Map mode. Keep physical modifier tracking and normal Alt pass-through unchanged.
Add a regression covering both Alt keys, trigger repeats and the eventual physical release. Verified with 36 native shortcut tests and real Windows menu/input checks.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: prevent Alt menu activation in all keyboard modes
Extend Windows Alt-only shortcut neutralization to Translate and Legacy. Keep the temporary Ctrl packets in Map mode so Legacy modifier synchronization cannot release Alt before Ctrl.
Extend the existing regression across keyboard modes and decode scan, virtual and control-key events. Verify 36 native tests and 34 Windows menu replay cases.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: initialize outgoing chat before shortcut dispatch
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: guard Windows Alt release in Flutter legacy shortcuts
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: coordinate Web shortcut dispatch and Alt modifier cleanup
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: distinguish AltGraph from ordinary Alt shortcuts
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: dispatch macOS Web shortcuts without waiting for keyup
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: support legacy peers in privacy mode shortcut
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: exclude AltGraph from Flutter shortcut matching
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix: exclude GTK AltGr input from raw shortcut matching
Signed-off-by: fufesou <linlong1266@gmail.com>
* test: trim redundant keyboard shortcut coverage
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(keyboard): prevent Cmd shortcuts from opening remote Start
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): guard Windows menu keys after Ctrl/Cmd swapping
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): align recording and display routing
Reject non-Apple AltGraph captures to match runtime filtering. Honor individual-display windows for next, previous, and all-display shortcuts.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): reject GTK AltGr chords in recorder
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(android): restore keyboard focus for modifier-first input
Focus the existing FlutterView when a modifier is pressed without native view focus. This restores shortcut-first input after returning to RustDesk while preserving focused inputs and normal key dispatch.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): release held keys before keyboard mode changes
Drain Flutter-forwarded keys before keyboard-mode shortcut actions so releases use the original encoding. This prevents held keys from remaining down after a Web Input source 2 mode change.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(i18n): use sentence case for shortcut labels
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(mobile): preserve touch modifiers in the input helper
Keep touch-selected modifiers visible after hiding the keyboard. Clear physical modifier releases locally in view-only mode so they do not reopen the helper.
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(web): preserve modifiers across Legacy-to-Map shortcuts
Signed-off-by: fufesou <linlong1266@gmail.com>
* fix(shortcuts): check support before registering all displays view
Signed-off-by: fufesou <linlong1266@gmail.com>
---------
Signed-off-by: fufesou <linlong1266@gmail.com>
Co-authored-by: fufesou <linlong1266@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
670 lines
28 KiB
Dart
670 lines
28 KiB
Dart
import 'dart:async';
|
|
import 'dart:convert';
|
|
|
|
import 'package:flutter/foundation.dart';
|
|
|
|
import '../common.dart';
|
|
import '../common/shared_state.dart' show PrivacyModeState;
|
|
import '../common/widgets/dialog.dart'
|
|
show desktopTryShowTabAuditDialogCloseCancelled;
|
|
import '../common/widgets/keyboard_shortcuts/shortcut_utils.dart';
|
|
import '../common/widgets/keyboard_shortcuts/shortcut_actions.dart';
|
|
import '../common/widgets/toolbar.dart'
|
|
show allowDisplaySwitchInPrivacyMode, showVirtualDisplayMenu;
|
|
import '../consts.dart';
|
|
import '../desktop/widgets/remote_toolbar.dart' show ToolbarState;
|
|
import 'chat_model.dart' show ChatModel, MessageKey, VoiceCallStatus;
|
|
import '../desktop/widgets/tabbar_widget.dart' show DesktopTabController;
|
|
import '../models/model.dart';
|
|
import '../models/platform_model.dart';
|
|
import '../models/state_model.dart';
|
|
|
|
typedef ShortcutCallback = FutureOr<void> Function();
|
|
|
|
/// Per-session shortcut dispatcher. Attached to FFI when a session is created.
|
|
///
|
|
/// The Rust matcher (src/keyboard/shortcuts.rs) emits `shortcut_triggered`
|
|
/// session events containing the matched `action` id. The session event
|
|
/// listener in [FfiModel.startEventListener] forwards those to this model
|
|
/// via [onTriggered], which runs whatever callback the toolbar / menu
|
|
/// builders previously registered for that action id.
|
|
class ShortcutModel {
|
|
static WeakReference<ShortcutModel>? _activeWebModel;
|
|
|
|
final WeakReference<FFI> parent;
|
|
final Map<String, ShortcutCallback> _callbacks = {};
|
|
final Map<String, ShortcutCallback> _refreshers = {};
|
|
|
|
ShortcutModel(this.parent);
|
|
|
|
/// Called by toolbar / menu builders to register what to do when the
|
|
/// matched shortcut fires.
|
|
void register(String actionId, ShortcutCallback callback) {
|
|
if (parent.target?.closed != false) return;
|
|
_callbacks[actionId] = callback;
|
|
_activeWebModel = WeakReference(this);
|
|
}
|
|
|
|
void unregister(String actionId) {
|
|
_callbacks.remove(actionId);
|
|
}
|
|
|
|
void registerRefresher(List<String> actionIds, ShortcutCallback refresh) {
|
|
if (parent.target?.closed != false) return;
|
|
for (final actionId in actionIds) {
|
|
_refreshers[actionId] = refresh;
|
|
}
|
|
}
|
|
|
|
void clear() {
|
|
_callbacks.clear();
|
|
_refreshers.clear();
|
|
if (identical(_activeWebModel?.target, this)) {
|
|
_activeWebModel = null;
|
|
}
|
|
}
|
|
|
|
static void onWebTriggered(String actionId) {
|
|
final model = _activeWebModel?.target;
|
|
if (model != null) {
|
|
model.onTriggered(actionId);
|
|
} else {
|
|
debugPrint('shortcut_triggered: no active web shortcut model');
|
|
}
|
|
}
|
|
|
|
/// Called by the session event listener when a `shortcut_triggered` event
|
|
/// arrives for this session.
|
|
///
|
|
/// The matcher has already consumed the chord. With no handler the action
|
|
/// is unavailable in this session (e.g. screenshot on a peer without
|
|
/// support), and the chord is a deliberate no-op: a bound chord always
|
|
/// belongs to RustDesk and is never forwarded to the remote.
|
|
void onTriggered(String actionId) {
|
|
if (parent.target?.closed != false) return;
|
|
unawaited(Future.sync(() async {
|
|
final refresh = _refreshers[actionId];
|
|
if (refresh != null) {
|
|
await refresh();
|
|
if (!identical(_refreshers[actionId], refresh)) return;
|
|
}
|
|
if (parent.target?.closed != false) return;
|
|
final cb = _callbacks[actionId];
|
|
if (cb != null) {
|
|
await cb();
|
|
} else {
|
|
debugPrint('shortcut_triggered: no handler for $actionId');
|
|
}
|
|
}).catchError((e, st) {
|
|
debugPrint('shortcut_triggered: handler failed for $actionId: $e\n$st');
|
|
}));
|
|
}
|
|
|
|
static String _configRaw = '';
|
|
static ShortcutConfig _config = ShortcutConfig.parse('');
|
|
static ShortcutConfig _activeConfig = _config;
|
|
|
|
/// The stored config, parsed once per distinct stored value. The Flutter
|
|
/// matcher reads it on every key press, so a key press costs one config
|
|
/// read and no JSON parsing while the config is unchanged.
|
|
/// Runtime matching requests [active] to exclude platform-hidden bindings
|
|
/// while retaining the stored config for other platforms.
|
|
static ShortcutConfig config({bool active = false}) {
|
|
final raw = bind.mainGetLocalOption(key: kShortcutLocalConfigKey);
|
|
if (raw != _configRaw) {
|
|
_config = ShortcutConfig.parse(raw);
|
|
_activeConfig = _config.forPlatform(currentPlatformCapabilities());
|
|
_configRaw = raw;
|
|
}
|
|
return active ? _activeConfig : _config;
|
|
}
|
|
|
|
/// Read the bindings JSON from LocalConfig. Returns a copy the caller may
|
|
/// edit.
|
|
static List<Map<String, dynamic>> readBindings() => [
|
|
for (final binding in config().bindings)
|
|
Map<String, dynamic>.of(binding)
|
|
];
|
|
|
|
static bool isEnabled() => config().enabled;
|
|
|
|
static bool isPassThrough() => config().passThrough;
|
|
|
|
/// Persistent companion to [isEnabled]: when on, the matchers return early
|
|
/// and every keystroke flows through to the remote (i.e. all bindings are
|
|
/// suspended). Stored in the same JSON blob so a single reload refreshes
|
|
/// both flags on every active matcher.
|
|
static Future<void> setPassThrough(bool v) async {
|
|
final raw = bind.mainGetLocalOption(key: kShortcutLocalConfigKey);
|
|
Map<String, dynamic> json = {};
|
|
if (raw.isNotEmpty) {
|
|
try {
|
|
json = jsonDecode(raw) as Map<String, dynamic>;
|
|
} catch (_) {
|
|
json = {};
|
|
}
|
|
}
|
|
json['pass_through'] = v;
|
|
await bind.mainSetLocalOption(
|
|
key: kShortcutLocalConfigKey, value: jsonEncode(json));
|
|
bind.mainReloadKeyboardShortcuts();
|
|
}
|
|
|
|
/// Flip the master `enabled` flag and persist. On the first enable we seed
|
|
/// the default bindings so common combos work out of the box; otherwise we
|
|
/// preserve whatever the user already has, an empty list included. Refreshes the matcher cache so
|
|
/// the change takes effect immediately (Rust on native, JS via the bridge
|
|
/// on Web).
|
|
static Future<void> setEnabled(bool v) async {
|
|
final raw = bind.mainGetLocalOption(key: kShortcutLocalConfigKey);
|
|
Map<String, dynamic> json = {};
|
|
if (raw.isNotEmpty) {
|
|
try {
|
|
json = jsonDecode(raw) as Map<String, dynamic>;
|
|
} catch (_) {
|
|
json = {};
|
|
}
|
|
}
|
|
json['enabled'] = v;
|
|
if (v && shouldSeedDefaultShortcutBindings(json)) {
|
|
json['bindings'] = filterDefaultBindingsForPlatform(
|
|
jsonDecode(bind.mainGetDefaultKeyboardShortcuts()) as List,
|
|
currentPlatformCapabilities(),
|
|
);
|
|
} else if (json.containsKey('bindings')) {
|
|
json['bindings'] = shortcutBindingMapsFrom(json['bindings']);
|
|
}
|
|
await bind.mainSetLocalOption(
|
|
key: kShortcutLocalConfigKey, value: jsonEncode(json));
|
|
bind.mainReloadKeyboardShortcuts();
|
|
}
|
|
|
|
/// Single source of truth for the per-platform "is this shortcut applicable"
|
|
/// decisions. Both [setEnabled]'s default-seeding pass and the configuration
|
|
/// page's reset / list-rendering paths read from here, so the seed list and
|
|
/// the visible action list can never disagree on which platform a given
|
|
/// action belongs to.
|
|
///
|
|
/// Capability rationale:
|
|
/// * Fullscreen / Toolbar / Pin: rendered wherever the
|
|
/// desktop layout applies (native desktop + Web). Native mobile is
|
|
/// permanently full-screen and doesn't have a desktop-style toolbar.
|
|
/// * Screenshot / Switch Sides: native desktop only. The Web bridge
|
|
/// throws UnimplementedError for `sessionTakeScreenshot`; mobile
|
|
/// toolbars don't surface either action.
|
|
/// * Tab navigation / Close Tab: only native desktop ships
|
|
/// `DesktopTabController`; Web's `RemotePage` is invoked without one.
|
|
/// * Recording: native desktop has the `_RecordMenu` widget +
|
|
/// `registerSessionShortcutActions` registration; native Android has
|
|
/// the `toolbarControls` entry; iOS short-circuits inside
|
|
/// `recordingModel.toggle()`; Web has no implementation.
|
|
/// * Reset Canvas: only the mobile toolbar builds the menu entry
|
|
/// (`isDefaultConn && isMobile` in `toolbarControls`).
|
|
/// * Voice Call: iOS has no audio capture implementation; Web bridge throws
|
|
/// `UnimplementedError` for both `sessionRequestVoiceCall` and
|
|
/// `sessionCloseVoiceCall`.
|
|
static ShortcutPlatformCapabilities currentPlatformCapabilities() {
|
|
final desktopLayout = isDesktop || isWeb;
|
|
return ShortcutPlatformCapabilities(
|
|
includeFullscreenShortcut: desktopLayout,
|
|
includeScreenshotShortcut: isDesktop,
|
|
includeRelativeMouseModeShortcut:
|
|
isDesktop && !(isLinux && bind.mainCurrentIsWayland()),
|
|
includeTabShortcuts: isDesktop,
|
|
includeToolbarShortcut: desktopLayout,
|
|
includeCloseTabShortcut: isDesktop,
|
|
includeSwitchSidesShortcut: isDesktop,
|
|
includeRecordingShortcut: !isWeb && !isIOS,
|
|
includeResetCanvasShortcut: isMobile,
|
|
includePinToolbarShortcut: desktopLayout,
|
|
includeViewModeShortcut: true,
|
|
includeVoiceCallShortcut: !isWeb && !isIOS,
|
|
excludedActions: Set.unmodifiable({
|
|
if (!isDesktop) ...[
|
|
kShortcutActionSwitchDisplayAll,
|
|
kShortcutActionToggleEnableFileCopyPaste,
|
|
],
|
|
if (isMobile) ...[
|
|
kShortcutActionKeyboardModeLegacy,
|
|
kShortcutActionKeyboardModeMap,
|
|
kShortcutActionKeyboardModeTranslate,
|
|
kShortcutActionToggleShowMyCursor,
|
|
kShortcutActionToggleZoomCursor,
|
|
],
|
|
}),
|
|
);
|
|
}
|
|
}
|
|
|
|
/// One parsed view of the `keyboard-shortcuts` LocalConfig value. Malformed
|
|
/// or missing input parses as disabled with no bindings.
|
|
class ShortcutConfig {
|
|
final bool enabled;
|
|
final bool passThrough;
|
|
final List<Map<String, dynamic>> bindings;
|
|
|
|
const ShortcutConfig._(this.enabled, this.passThrough, this.bindings);
|
|
|
|
ShortcutConfig forPlatform(ShortcutPlatformCapabilities capabilities) {
|
|
final visible = allActionEntries(
|
|
filterKeyboardShortcutActionGroupsForPlatform(capabilities))
|
|
.map((entry) => entry.id)
|
|
.toSet();
|
|
final hidden = allActionEntries(kKeyboardShortcutActionGroups)
|
|
.map((entry) => entry.id)
|
|
.where((id) => !visible.contains(id))
|
|
.toSet();
|
|
return ShortcutConfig._(
|
|
enabled,
|
|
passThrough,
|
|
List.unmodifiable(bindings.where((b) => !hidden.contains(b['action']))),
|
|
);
|
|
}
|
|
|
|
static ShortcutConfig parse(String raw) {
|
|
if (raw.isEmpty) return const ShortcutConfig._(false, false, []);
|
|
try {
|
|
final parsed = jsonDecode(raw) as Map<String, dynamic>;
|
|
return ShortcutConfig._(
|
|
parsed['enabled'] == true,
|
|
parsed['pass_through'] == true,
|
|
List.unmodifiable(shortcutBindingMapsFrom(parsed['bindings'])),
|
|
);
|
|
} catch (_) {
|
|
return const ShortcutConfig._(false, false, []);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Register the default-bound shortcut actions that aren't already wired by
|
|
/// `toolbarControls(...)` (which handles things like Ctrl+Alt+Shift+Del and the
|
|
/// screenshot action). Called once per session from the desktop / mobile
|
|
/// remote page, after the toolbar registrations have run.
|
|
///
|
|
/// We register unconditionally — even when shortcuts are master-disabled —
|
|
/// because the matcher (Rust + JS) gates dispatch via the `enabled` flag,
|
|
/// so registered closures are functionally invisible until the user flips
|
|
/// shortcuts on. This keeps the wiring simple (no rebind callbacks across
|
|
/// sessions) and lets the user toggle shortcuts mid-session without
|
|
/// reconnecting.
|
|
///
|
|
/// [tabController] is the desktop window's tab controller; `null` on mobile /
|
|
/// web (where tab-switch shortcuts don't apply).
|
|
///
|
|
/// Each callback below is a no-op when the underlying state required to
|
|
/// service the action isn't available (e.g. only one display, only one tab).
|
|
void registerSessionShortcutActions(
|
|
FFI ffi, {
|
|
DesktopTabController? tabController,
|
|
ToolbarState? toolbarState,
|
|
}) {
|
|
final sessionId = ffi.sessionId;
|
|
|
|
// Note on disposal: every closure registered below captures `ffi` via
|
|
// closure environment, so the FFI object stays alive for the duration of
|
|
// the closure's execution — even across awaits, even if the session is
|
|
// closed mid-execution. We therefore don't add per-closure liveness
|
|
// guards: a `WeakReference<FFI>` check would never go null while the
|
|
// closure is on the call stack, and the underlying `bind.session*` /
|
|
// model setters tolerate stale-session calls (they no-op on torn-down
|
|
// sessions). ShortcutModel.onTriggered's existing entry guard
|
|
// (`_callbacks` lookup returning null after disposal) is the actual
|
|
// liveness gate.
|
|
|
|
// Toggle Fullscreen — available wherever the desktop layout renders
|
|
// (native desktop + every Web browser, since Web uses the desktop
|
|
// RemotePage). `stateGlobal.setFullscreen` handles native window vs.
|
|
// browser fullscreen. Native mobile is permanently full-screen, so the
|
|
// action is intentionally not registered there.
|
|
if (isDesktop || isWeb) {
|
|
ffi.shortcutModel.register(kShortcutActionToggleFullscreen, () {
|
|
stateGlobal.setFullscreen(!stateGlobal.fullscreen.value);
|
|
});
|
|
}
|
|
|
|
// Toggle Recording — desktop only here. Mobile already wires this through
|
|
// `toolbarControls` (which adds a recording entry on `!(isDesktop||isWeb)`),
|
|
// but the desktop toolbar uses a separate `_RecordMenu` widget that has no
|
|
// `actionId`. Without this explicit registration a desktop user could bind
|
|
// Toggle Recording in settings and the press would have no handler.
|
|
// `recordingModel.toggle()` itself short-circuits on iOS and on sessions
|
|
// without recording permission.
|
|
if (isDesktop) {
|
|
ffi.shortcutModel.register(kShortcutActionToggleRecording, () {
|
|
ffi.recordingModel.toggle();
|
|
});
|
|
}
|
|
|
|
void openDisplay(int display, PeerInfo pi, {bool updateCursorPos = true}) {
|
|
if (isDesktop &&
|
|
pi.isSupportMultiDisplay &&
|
|
bind.sessionGetDisplaysAsIndividualWindows(sessionId: sessionId) ==
|
|
'Y') {
|
|
openMonitorInNewTabOrWindow(display, ffi.id, pi);
|
|
} else {
|
|
openMonitorInTheSameTab(display, ffi, pi,
|
|
updateCursorPos: updateCursorPos);
|
|
}
|
|
}
|
|
|
|
// Switch Display Next / Prev — requires the peer to have at least 2
|
|
// displays. From the "All displays" merged view, Next jumps to display 0
|
|
// and Prev to the last display, so the user can always escape the merged
|
|
// view via these shortcuts.
|
|
void switchDisplayBy(int delta) {
|
|
final pi = ffi.ffiModel.pi;
|
|
final privacyMode = PrivacyModeState.find(ffi.id).value;
|
|
if (privacyMode.isNotEmpty &&
|
|
!allowDisplaySwitchInPrivacyMode(pi, privacyMode)) {
|
|
return;
|
|
}
|
|
final count = pi.displays.length;
|
|
if (count <= 1) return;
|
|
final current = pi.currentDisplay;
|
|
final int next;
|
|
if (current == kAllDisplayValue) {
|
|
next = delta > 0 ? 0 : count - 1;
|
|
} else {
|
|
next = ((current + delta) % count + count) % count;
|
|
}
|
|
openDisplay(next, pi, updateCursorPos: isMobile);
|
|
}
|
|
|
|
ffi.shortcutModel.register(kShortcutActionSwitchDisplayNext, () {
|
|
switchDisplayBy(1);
|
|
});
|
|
ffi.shortcutModel.register(kShortcutActionSwitchDisplayPrev, () {
|
|
switchDisplayBy(-1);
|
|
});
|
|
|
|
// Switch to all-monitors view — mirrors the toolbar Monitor menu's
|
|
// "all monitors" button (only built when peer has >1 display). Not a
|
|
// toggle: the toolbar button just sets the merged view; another action
|
|
// (Switch to next/previous display, or another monitor button) takes
|
|
// you back to a single display.
|
|
//
|
|
// For same-tab view, use `openMonitorInTheSameTab` rather than calling
|
|
// `sessionSwitchDisplay` with `[kAllDisplayValue]` directly — the toolbar
|
|
// path treats `kAllDisplayValue` as a UI sentinel and expands it to the
|
|
// real display index list (`[0, 1, ...]`) before sending, then updates
|
|
// local FfiModel state. Sending `[-1]` raw produces a wire value the
|
|
// remote can't act on and skips the local state update, so the merged
|
|
// view never engages.
|
|
ffi.shortcutModel.register(kShortcutActionSwitchDisplayAll, () {
|
|
final pi = ffi.ffiModel.pi;
|
|
final privacyMode = PrivacyModeState.find(ffi.id).value;
|
|
if (privacyMode.isNotEmpty &&
|
|
!allowDisplaySwitchInPrivacyMode(pi, privacyMode)) {
|
|
return;
|
|
}
|
|
if (!pi.isSupportMultiDisplay || pi.displays.length <= 1) return;
|
|
if (pi.currentDisplay == kAllDisplayValue) return;
|
|
openDisplay(kAllDisplayValue, pi);
|
|
});
|
|
|
|
// Switch tab next / prev — desktop only. The remote-screen tabs live in
|
|
// the window-scoped DesktopTabController, not on the FFI itself, so we
|
|
// need the controller from the page that owns this session. We
|
|
// intentionally don't expose positional ("Switch to tab N") shortcuts:
|
|
// counting tabs in a long list is impractical, and AnyDesk / Chrome
|
|
// standard practice is to favour next/prev navigation.
|
|
if (tabController != null) {
|
|
void switchTabBy(int delta) {
|
|
final tabs = tabController.state.value.tabs;
|
|
if (tabs.length <= 1) return;
|
|
final cur = tabs.indexWhere((t) => t.key == ffi.id);
|
|
if (cur < 0) return;
|
|
final next = (cur + delta + tabs.length) % tabs.length;
|
|
tabController.jumpTo(next);
|
|
}
|
|
|
|
ffi.shortcutModel
|
|
.register(kShortcutActionSwitchTabNext, () => switchTabBy(1));
|
|
ffi.shortcutModel
|
|
.register(kShortcutActionSwitchTabPrev, () => switchTabBy(-1));
|
|
|
|
// Close Tab — desktop only. Mirrors the tab right-click "Close" entry,
|
|
// including the audit-log confirmation dialog so a shortcut close goes
|
|
// through the same path as a menu close.
|
|
ffi.shortcutModel.register(kShortcutActionCloseTab, () async {
|
|
if (await desktopTryShowTabAuditDialogCloseCancelled(
|
|
id: ffi.id,
|
|
tabController: tabController,
|
|
)) {
|
|
return;
|
|
}
|
|
tabController.closeBy(ffi.id);
|
|
});
|
|
}
|
|
|
|
// Toggle Toolbar — desktop only. ToolbarState is window/session-scoped,
|
|
// owned by the RemotePage that hosts this session.
|
|
if (toolbarState != null) {
|
|
ffi.shortcutModel.register(kShortcutActionToggleToolbar, () {
|
|
toolbarState.switchHide(sessionId);
|
|
});
|
|
ffi.shortcutModel.register(kShortcutActionPinToolbar, () {
|
|
toolbarState.switchPin();
|
|
});
|
|
}
|
|
|
|
// Toggle Chat overlay (open/close the chat panel for this session).
|
|
// _ChatMenu is a standalone toolbar icon — not part of any toolbar
|
|
// helper that returns a TToggleMenu list — so its handler is wired
|
|
// here rather than picked up by helper auto-register.
|
|
ffi.shortcutModel.register(kShortcutActionToggleChat, () {
|
|
ffi.chatModel.changeCurrentKey(MessageKey(ffi.id, ChatModel.clientModeID));
|
|
ffi.chatModel.toggleChatOverlay();
|
|
});
|
|
|
|
// Toggle Voice Call — start when idle, hang up when active. Mirrors the
|
|
// toolbar's `_VoiceCallMenu` state-driven button. Web bridge throws
|
|
// UnimplementedError on both sessionRequestVoiceCall and
|
|
// sessionCloseVoiceCall; iOS has no audio capture implementation.
|
|
if (!isWeb && !isIOS) {
|
|
ffi.shortcutModel.register(kShortcutActionToggleVoiceCall, () {
|
|
final status = ffi.chatModel.voiceCallStatus.value;
|
|
if (status == VoiceCallStatus.connected ||
|
|
status == VoiceCallStatus.waitingForResponse) {
|
|
bind.sessionCloseVoiceCall(sessionId: sessionId);
|
|
} else {
|
|
bind.sessionRequestVoiceCall(sessionId: sessionId);
|
|
}
|
|
});
|
|
}
|
|
|
|
// ── Inline _KeyboardMenu items + actions with no toolbar TToggleMenu/TRadioMenu ─
|
|
// The toolbar's TToggleMenu / TRadioMenu helpers (toolbarDisplayToggle,
|
|
// toolbarCursor, toolbarKeyboardToggles, toolbarCodec, toolbarPrivacyMode,
|
|
// toolbarViewStyle, toolbarImageQuality) auto-register their tagged entries
|
|
// from the bottom of each helper. The handlers below cover what those
|
|
// helpers DON'T own:
|
|
// * Show my cursor / Keyboard mode (Map/Translate/Legacy) / View Only
|
|
// (desktop) — built as widgets directly in `_KeyboardMenu`, not as
|
|
// TToggleMenu lists. (Mobile View Only IS in toolbarDisplayToggle and
|
|
// auto-registers; the desktop session-start handler below registers
|
|
// first and the helper's auto-register on mobile takes over after its
|
|
// unawaited future resolves.)
|
|
// * Plug out all virtual displays — built in `getVirtualDisplayMenuChildren`
|
|
// as a MenuButton, not a TToggleMenu.
|
|
// * Toggle Input Source — cycle action; the toolbar exposes per-source
|
|
// radios but no single "cycle to next source" entry.
|
|
|
|
// Show my cursor — toolbar (`_KeyboardMenu.showMyCursor`) pushes the new
|
|
// value into FfiModel.setShowMyCursor and auto-enables view-only when the
|
|
// toggle goes on, so the user can never control the remote with their own
|
|
// cursor visible.
|
|
ffi.shortcutModel.register(kShortcutActionToggleShowMyCursor, () async {
|
|
await bind.sessionToggleOption(
|
|
sessionId: sessionId, value: kOptionToggleShowMyCursor);
|
|
final showMyCursor = await bind.sessionGetToggleOption(
|
|
sessionId: sessionId, arg: kOptionToggleShowMyCursor) ??
|
|
false;
|
|
ffi.ffiModel.setShowMyCursor(showMyCursor);
|
|
if (showMyCursor && !ffi.ffiModel.viewOnly) {
|
|
await bind.sessionToggleOption(
|
|
sessionId: sessionId, value: kOptionToggleViewOnly);
|
|
final viewOnly = await bind.sessionGetToggleOption(
|
|
sessionId: sessionId, arg: kOptionToggleViewOnly) ??
|
|
false;
|
|
ffi.ffiModel.setViewOnly(ffi.id, viewOnly);
|
|
}
|
|
});
|
|
|
|
// Keyboard mode (Map / Translate / Legacy). Mirrors the radio buttons in
|
|
// `_KeyboardMenu.keyboardMode()` (built as RdoMenuButton, not TRadioMenu).
|
|
void registerKeyboardMode(String actionId, String mode) {
|
|
ffi.shortcutModel.register(actionId, () async {
|
|
if (!ffi.ffiModel.keyboard ||
|
|
ffi.ffiModel.viewOnly ||
|
|
!bind.sessionIsKeyboardModeSupported(
|
|
sessionId: sessionId, mode: mode) ||
|
|
(ffi.ffiModel.pi.isWayland && mode != kKeyMapMode)) {
|
|
return;
|
|
}
|
|
if (isInputSourceFlutter && isDesktop) {
|
|
final modeOnly = bind.sessionIsKeyboardModeSupported(
|
|
sessionId: sessionId, mode: kKeyMapMode)
|
|
? kKeyMapMode
|
|
: kKeyLegacyMode;
|
|
if (mode != modeOnly) return;
|
|
}
|
|
await bind.sessionSetKeyboardMode(sessionId: sessionId, value: mode);
|
|
await ffi.inputModel.updateKeyboardMode();
|
|
});
|
|
}
|
|
|
|
registerKeyboardMode(kShortcutActionKeyboardModeMap, kKeyMapMode);
|
|
registerKeyboardMode(kShortcutActionKeyboardModeTranslate, kKeyTranslateMode);
|
|
registerKeyboardMode(kShortcutActionKeyboardModeLegacy, kKeyLegacyMode);
|
|
|
|
// Plug out all virtual displays (Windows + IDD only). Mirrors the toolbar's
|
|
// "Plug out all" button — present in both IDD modes (RustDesk + Amyuni),
|
|
// built as a MenuButton inside `getVirtualDisplayMenuChildren`.
|
|
ffi.shortcutModel.register(kShortcutActionPlugOutAllVirtualDisplays, () {
|
|
if (ffi.connType != ConnType.defaultConn ||
|
|
!showVirtualDisplayMenu(ffi) ||
|
|
PrivacyModeState.find(ffi.id).value.isNotEmpty ||
|
|
(ffi.ffiModel.pi.isAmyuniIdd &&
|
|
ffi.ffiModel.pi.amyuniVirtualDisplayCount == 0)) {
|
|
return;
|
|
}
|
|
bind.sessionToggleVirtualDisplay(
|
|
sessionId: sessionId,
|
|
index: kAllVirtualDisplay,
|
|
on: false,
|
|
);
|
|
});
|
|
|
|
// Privacy mode 1 / 2 — fallback handlers for the single-impl and null-impls
|
|
// branches of `toolbarPrivacyMode`. The multi-impl branch tags each entry
|
|
// with the matching actionId and `_registerToggleMenuShortcuts` overrides
|
|
// these closures with the toolbar's own onChanged. But when the peer only
|
|
// advertises a single impl (older Linux peers, certain platform configs)
|
|
// toolbarPrivacyMode returns a `getDefaultMenu` entry without an actionId,
|
|
// so the auto-register pass skips it — these fallbacks are what actually
|
|
// wire the shortcut in that case.
|
|
String? findPrivacyImpl(String nameKey) {
|
|
final impls = ffi.ffiModel.pi
|
|
.platformAdditions[kPlatformAdditionsSupportedPrivacyModeImpl]
|
|
as List<dynamic>?;
|
|
if (impls == null) return null;
|
|
for (final e in impls) {
|
|
if (e is List && e.length >= 2 && e[1] == nameKey) return e[0] as String;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
bool checkPrivacyModeAllowed(String implKey) {
|
|
final ffiModel = ffi.ffiModel;
|
|
final pi = ffiModel.pi;
|
|
final privacyMode = PrivacyModeState.find(ffi.id).value;
|
|
if (ffi.connType != ConnType.defaultConn ||
|
|
ffiModel.viewOnly ||
|
|
(privacyMode.isEmpty &&
|
|
(!pi.features.privacyMode || !ffiModel.keyboard))) {
|
|
return false;
|
|
}
|
|
if (privacyMode == implKey) return true;
|
|
if (ffiModel.permissions['privacy_mode'] == false) return false;
|
|
if (allowDisplaySwitchInPrivacyMode(pi, implKey) ||
|
|
(pi.currentDisplay == 0 &&
|
|
!bind.sessionIsMultiUiSession(sessionId: sessionId))) {
|
|
return true;
|
|
}
|
|
msgBox(sessionId, 'custom-nook-nocancel-hasclose', 'info',
|
|
'Please switch to Display 1 first', '', ffi.dialogManager);
|
|
return false;
|
|
}
|
|
|
|
// Match the multi-impl branch of `toolbarPrivacyMode`: turn this impl on iff
|
|
// the active impl isn't already this one. Comparing `.value == implKey`
|
|
// (rather than `.value.isEmpty`) means pressing the mode-1 shortcut while
|
|
// mode 2 is on correctly turns mode 1 ON, instead of misreading the
|
|
// "any-mode-active" state as "this-mode-active" and toggling OFF.
|
|
ffi.shortcutModel.register(kShortcutActionPrivacyMode1, () {
|
|
if (ffi.ffiModel.pi
|
|
.platformAdditions[kPlatformAdditionsSupportedPrivacyModeImpl] ==
|
|
null) {
|
|
// Older peers use the legacy option instead of a named implementation.
|
|
if (!checkPrivacyModeAllowed(kPrivacyModeImplMag)) return;
|
|
bind.sessionToggleOption(sessionId: sessionId, value: 'privacy-mode');
|
|
return;
|
|
}
|
|
final implKey = findPrivacyImpl('privacy_mode_impl_mag_tip');
|
|
if (implKey == null) return;
|
|
if (!checkPrivacyModeAllowed(implKey)) return;
|
|
bind.sessionTogglePrivacyMode(
|
|
sessionId: sessionId,
|
|
implKey: implKey,
|
|
on: PrivacyModeState.find(ffi.id).value != implKey,
|
|
);
|
|
});
|
|
ffi.shortcutModel.register(kShortcutActionPrivacyMode2, () {
|
|
final implKey = findPrivacyImpl('privacy_mode_impl_virtual_display_tip');
|
|
if (implKey == null) return;
|
|
if (!checkPrivacyModeAllowed(implKey)) return;
|
|
bind.sessionTogglePrivacyMode(
|
|
sessionId: sessionId,
|
|
implKey: implKey,
|
|
on: PrivacyModeState.find(ffi.id).value != implKey,
|
|
);
|
|
});
|
|
|
|
// View Only — desktop toolbar exposes this inline in `_KeyboardMenu.viewMode`
|
|
// (mobile is in toolbarDisplayToggle and goes through helper auto-register).
|
|
// Mirrors the desktop callback: toggle + sync FfiModel.viewOnly +
|
|
// FfiModel.showMyCursor (the toolbar keeps these in step).
|
|
ffi.shortcutModel.register(kShortcutActionToggleViewOnly, () async {
|
|
await bind.sessionToggleOption(
|
|
sessionId: sessionId, value: kOptionToggleViewOnly);
|
|
final viewOnly = await bind.sessionGetToggleOption(
|
|
sessionId: sessionId, arg: kOptionToggleViewOnly) ??
|
|
false;
|
|
ffi.ffiModel.setViewOnly(ffi.id, viewOnly);
|
|
final showMyCursor = await bind.sessionGetToggleOption(
|
|
sessionId: sessionId, arg: kOptionToggleShowMyCursor) ??
|
|
false;
|
|
ffi.ffiModel.setShowMyCursor(showMyCursor);
|
|
});
|
|
|
|
// Toggle Reverse mouse wheel — read current 'Y'/'N' (falling back to user
|
|
// default), flip, write back.
|
|
ffi.shortcutModel.register(kShortcutActionToggleReverseMouseWheel, () async {
|
|
if (!ffi.ffiModel.keyboard || ffi.ffiModel.viewOnly) return;
|
|
var cur = bind.sessionGetReverseMouseWheelSync(sessionId: sessionId) ?? '';
|
|
if (cur == '') {
|
|
cur = bind.mainGetUserDefaultOption(key: kKeyReverseMouseWheel);
|
|
}
|
|
final next = cur == 'Y' ? 'N' : 'Y';
|
|
await bind.sessionSetReverseMouseWheel(sessionId: sessionId, value: next);
|
|
});
|
|
|
|
// Toggle Relative mouse mode (gaming mode). Desktop only.
|
|
if (isDesktop && !isWeb) {
|
|
ffi.shortcutModel.register(kShortcutActionToggleRelativeMouseMode, () {
|
|
ffi.inputModel.toggleRelativeMouseMode();
|
|
});
|
|
}
|
|
}
|