github/sub2api
4
0
Fork 0
mirror of https://github.com/Wei-Shaw/sub2api.git synced 2026-10-23 05:51:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(payment): prefix order ID with sub2_ for third-party providers

Browse Source 
Add formatOrderID/parseOrderID helpers to prepend "sub2_" prefix to
order IDs sent to EasyPay, Alipay, Wxpay, and Stripe. This makes our
orders identifiable in third-party dashboards and prevents ID collision.

Callback handlers strip the prefix before looking up the DB record.
Internal audit logs keep using raw DB IDs.
This commit is contained in:
erio
2026-04-06 16:43:59 +08:00
parent d25669ab52
commit 2f41c71957
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/internal/service/payment_service.go
+17 -4
View File
@@ -45,8 +45,21 @@ const (
maxPageSize = 100
topUsersLimit = 10
amountToleranceCNY = 0.01
orderIDPrefix = "sub2_"
)
// formatOrderID converts an internal DB order ID to the external order ID sent to payment providers.
func formatOrderID(id int64) string {
return orderIDPrefix + strconv.FormatInt(id, 10)
}
// parseOrderID extracts the internal DB order ID from an external order ID returned by payment providers.
func parseOrderID(externalID string) (int64, error) {
trimmed := strings.TrimPrefix(externalID, orderIDPrefix)
return strconv.ParseInt(trimmed, 10, 64)
}
type CreateOrderRequest struct {
UserID int64
Amount float64
@@ -322,7 +335,7 @@ func (s *PaymentService) invokeProvider(ctx context.Context, order *dbent.Paymen
return nil, infraerrors.TooManyRequests("NO_AVAILABLE_INSTANCE", "no available payment instance")
}
subject := s.buildPaymentSubject(plan, payAmountStr, cfg)
pr, err := provider.CreatePayment(ctx, payment.CreatePaymentRequest{OrderID: strconv.FormatInt(order.ID, 10), Amount: payAmountStr, PaymentType: req.PaymentType, Subject: subject, ClientIP: req.ClientIP, IsMobile: req.IsMobile})
pr, err := provider.CreatePayment(ctx, payment.CreatePaymentRequest{OrderID: formatOrderID(order.ID), Amount: payAmountStr, PaymentType: req.PaymentType, Subject: subject, ClientIP: req.ClientIP, IsMobile: req.IsMobile})
if err != nil {
return nil, infraerrors.ServiceUnavailable("PAYMENT_GATEWAY_ERROR", "payment method is temporarily unavailable")
}
@@ -444,7 +457,7 @@ func (s *PaymentService) checkPaid(ctx context.Context, o *dbent.PaymentOrder) s
return ""
}
if resp.Status == "paid" {
_ = s.HandlePaymentNotification(ctx, &payment.PaymentNotification{TradeNo: o.PaymentTradeNo, OrderID: strconv.FormatInt(o.ID, 10), Amount: resp.Amount, Status: "success"}, prov.ProviderKey())
_ = s.HandlePaymentNotification(ctx, &payment.PaymentNotification{TradeNo: o.PaymentTradeNo, OrderID: formatOrderID(o.ID), Amount: resp.Amount, Status: "success"}, prov.ProviderKey())
return "already_paid"
}
if cp, ok := prov.(payment.CancelableProvider); ok {
@@ -457,7 +470,7 @@ func (s *PaymentService) HandlePaymentNotification(ctx context.Context, n *payme
if n.Status != "success" {
return nil
}
oid, err := strconv.ParseInt(n.OrderID, 10, 64)
oid, err := parseOrderID(n.OrderID)
if err != nil {
return fmt.Errorf("invalid order ID: %s", n.OrderID)
}
@@ -778,7 +791,7 @@ func (s *PaymentService) gwRefund(ctx context.Context, p *RefundPlan) error {
if err != nil {
return fmt.Errorf("get provider: %w", err)
}
_, err = prov.Refund(ctx, payment.RefundRequest{TradeNo: p.Order.PaymentTradeNo, OrderID: strconv.FormatInt(p.Order.ID, 10), Amount: strconv.FormatFloat(p.GatewayAmount, 'f', 2, 64), Reason: p.Reason})
_, err = prov.Refund(ctx, payment.RefundRequest{TradeNo: p.Order.PaymentTradeNo, OrderID: formatOrderID(p.Order.ID), Amount: strconv.FormatFloat(p.GatewayAmount, 'f', 2, 64), Reason: p.Reason})
return err
}