github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 14:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(completion): respect identifier quoting for oracle completions

Browse Source
This commit is contained in:
Melody Ruch authored and GitHub committed 2026-09-20 19:10:29 +08:00
1 parent 99d2aa5f13
commit 2a8e329d05
3 files changed
+29 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/lib/sql/sqlCompletion.ts
+5 -1
View File
@@ -1548,6 +1548,7 @@ export interface SqlCompletionProviderInput {
keywordCase?: SqlKeywordCase;
functionCase?: SqlKeywordCase;
autoAliasTables?: boolean;
quoteIdentifiers?: boolean;
}
export function buildSqlCompletionItems(
@@ -1567,6 +1568,7 @@ export function buildSqlCompletionItems(
keywordCase?: SqlKeywordCase;
functionCase?: SqlKeywordCase;
autoAliasTables?: boolean;
quoteIdentifiers?: boolean;
},
): SqlCompletionItem[] {
if (isSqlCompletionSuppressedContext(sql, cursor, input)) return [];
@@ -1589,7 +1591,9 @@ class SqlCompletionProvider {
private readonly input: SqlCompletionProviderInput,
) {
this.t = input.translations;
this.dialect = sqlCompletionApplyDialect(input.databaseType, input.dialect);
const dialect = sqlCompletionApplyDialect(input.databaseType, input.dialect);
// "Quote identifiers in generated SQL" off: Oracle completion inserts bare names instead of quoting lowercase ones.
this.dialect = dialect === "oracle" && input.quoteIdentifiers === false ? undefined : dialect;
this.databaseType = input.databaseType;
}